Skip to content

[feature] Adds new xmldb-api security services#6520

Merged
line-o merged 1 commit into
eXist-db:developfrom
reinhapa:feature/xmldb-api
Jun 29, 2026
Merged

[feature] Adds new xmldb-api security services#6520
line-o merged 1 commit into
eXist-db:developfrom
reinhapa:feature/xmldb-api

Conversation

@reinhapa

@reinhapa reinhapa commented Jun 24, 2026

Copy link
Copy Markdown
Member

Adds the following missing exist implementations for the XML:DB API Services:

  • PermissionManagementService
  • UserPrincipalLookupService

@reinhapa reinhapa force-pushed the feature/xmldb-api branch 12 times, most recently from 85a4c63 to 6d96854 Compare June 25, 2026 04:48
@reinhapa reinhapa marked this pull request as ready for review June 25, 2026 07:14
@reinhapa reinhapa requested a review from a team as a code owner June 25, 2026 07:14
@reinhapa reinhapa force-pushed the feature/xmldb-api branch 6 times, most recently from ef3ecda to 5edadfa Compare June 26, 2026 08:33
Signed-off-by: Patrick Reinhart <patrick@reini.net>
@reinhapa reinhapa force-pushed the feature/xmldb-api branch from 5edadfa to 80d9753 Compare June 26, 2026 13:50
@reinhapa reinhapa requested review from dizzzz and duncdrum June 26, 2026 20:17

@duncdrum duncdrum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Two questions no blockers

Comment thread exist-core/src/test/java/org/exist/xmldb/EXistAttributesTest.java
@duncdrum duncdrum requested a review from a team June 27, 2026 10:14

@dizzzz dizzzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Nice work


@Override
public String getVersion() throws XMLDBException {
return "1.0";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this follow the xmldb version? V2?

@reinhapa reinhapa Jun 27, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this should represent the implementer version for this aervice.

@line-o line-o merged commit d55d75e into eXist-db:develop Jun 29, 2026
9 checks passed
@reinhapa reinhapa deleted the feature/xmldb-api branch June 29, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants