Skip to content

Improve build#317

Merged
duncdrum merged 7 commits into
eXist-db:masterfrom
line-o:improve/build
Aug 25, 2025
Merged

Improve build#317
duncdrum merged 7 commits into
eXist-db:masterfrom
line-o:improve/build

Conversation

@line-o
Copy link
Copy Markdown
Member

@line-o line-o commented Aug 18, 2025

Cherry picked commits from #313 + a minor tweak

adamretter and others added 6 commits August 18, 2025 19:54
Artifacts were generated in src/, instead these go to target/ now.
These are useful when reading the build output to diagnose issues
Profiles were chosen based on github specific info.
By default on a local machine Cypress should run without recording
when 'mvn verify' is run.
On CI Cypress will run with recording.
Options can be overriden locally on in CI with 'mvn -P'.
@adamretter
Copy link
Copy Markdown
Contributor

@line-o I am just wondering... what's the purpose of this PR? It looks the same as #313

Also, remove OS from matrix as there was only one option to begin with.
@dizzzz dizzzz requested review from dizzzz, duncdrum and reinhapa and removed request for duncdrum August 18, 2025 18:41
Copy link
Copy Markdown
Member

@dizzzz dizzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@line-o
Copy link
Copy Markdown
Member Author

line-o commented Aug 18, 2025

@adamretter Your draft PR contained a number of excellent commits. I would have pulled it in were it not for the conflict in Cypress versions (upgrade to 10 but we are already on 14). Plus, I wanted to add a few tweaks on top of that.

@dizzzz
Copy link
Copy Markdown
Member

dizzzz commented Aug 18, 2025

As written on top, these are cherry picks from your PR, most of it was very useful.
Most significant changes: we use a much newer version of cypress, and we had some parts that a bit difficult to understand (names of id's, unclear how they were correlated). Finally we updated the test matrix.

@adamretter
Copy link
Copy Markdown
Contributor

adamretter commented Aug 19, 2025

@line-o @dizzzz Im very sad to see that my input has been ignored. We were not on Cypress 14 until my concerns about that were completely ignored and that change made anyway. Now without any notice to me, and without even engaging in a conversation with me, my work has been taken, and used, whilst duplicating effort I already made. These actions have been revealing. It is now very clear to everyone outside of this project, that this is not at all a collaborative project, nor does it welcome external contributions. The invite publicly given to me at MarkupUK to collaborate on eXist-db Apps was apparently a hollow piece of face saving publicity. I regret spending my time on this project, it's now clear to me it's been a waste of my time, and that my repeated attempts to engage and collaborate have fallen on already deaf ears.

@dizzzz
Copy link
Copy Markdown
Member

dizzzz commented Aug 19, 2025

@adamretter your comments and contributions are certainly NOT ignored! That is not fair to anyone.

As you state it is a community based project, and in the community there are more voices, opinions, insights, experiences and solutions, not only yours.

So in the community call we took all options seriously, we investigated things, we considered all options and in the end we took the way the community thought it was the best way to go.

IMO that is the way it should go; 'one voice' should not have a veto or something like that.

@duncdrum duncdrum merged commit 3043596 into eXist-db:master Aug 25, 2025
4 checks passed
@line-o line-o deleted the improve/build branch August 25, 2025 18:43
@line-o line-o mentioned this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants