You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you've build a cabal project against multiple sandboxes, you'll end up with all of their cabal_macros.h headers included with -optP, which leads to errors like:
In file included from <command-line>:8:0:
[..]/dist/dist-sandbox-4f8d9efc/build/autogen/cabal_macros.h:11:0:
error: "VERSION_OpenGL" redefined [-Werror]
#define VERSION_OpenGL "2.12.0.1"
^
I believe it's all handled correctly in ghc-mod now with cabal-helper, and I haven't had any problems after removing the include paths.
I haven't extensively tested this, tracked down the ghc-mod version requirement (I'm using HEAD), or updated tests, so [wip].
How on earth can you even build agains multiple sandboxes O_o? Can you link me to some docs? But it's nice that we're handling that correctly (by accident) I guess :)
Not multiple sandboxes in a single build, but having multiple dist-sandbox directories because at some point it's been built to different sandboxes. This can happen after changing cabal or ghc versions without cleaning. I imagine it can also happen if you use add-source from multiple sandboxes.
How on earth can you even build agains multiple sandboxes O_o? Can you link me to some docs? But it's nice that we're handling that correctly (by accident) I guess :)
—
Reply to this email directly or view it on GitHub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you've build a cabal project against multiple sandboxes, you'll end up with all of their cabal_macros.h headers included with -optP, which leads to errors like:
I believe it's all handled correctly in ghc-mod now with cabal-helper, and I haven't had any problems after removing the include paths.
I haven't extensively tested this, tracked down the ghc-mod version requirement (I'm using HEAD), or updated tests, so [wip].
Any thoughts?