Merge branch 'main' into issue-903-tutorial-for-open_virtual_dataset-using-TEMPO-data

Author: danielfromearth

.github/ISSUE_TEMPLATE/bug.yml

@@ -3,8 +3,8 @@ description: >
   A bug is an issue that differs from documentation or has unexpected behavior.
 title: "[BUG] {{ title }}"
 labels:
-  - Bug
-  - Needs Triage
+  - "type: bug"
+  - "needs: triage"
 body:
   - type: checkboxes
     attributes:

.github/ISSUE_TEMPLATE/experience-report.yml

@@ -0,0 +1,13 @@
+name: '🗺️ Experience report'
+description: 'Help us level up Earthaccess by sharing your unfiltered experiences, wins, and struggles'
+labels:
+  - 'type: experience report'
+body:
+  - type: 'textarea'
+    attributes:
+      label: 'Description'
+      description: |
+        Provide detailed feedback on your Earthaccess experience, including successes, challenges, and suggestions for improvement.
+        Your insights will inform our development roadmap and community efforts.
+    validations:
+      required: true

.github/workflows/integration-test-review.yml

@@ -19,29 +19,76 @@ jobs:
           require: write
           username: ${{ github.triggering_actor }}
 
-      - name: Add PR comment when user does not have write permission
+      # The remaining steps are run only if the triggering actor (user) does NOT have
+      # write permission for the repo, in which case, the purpose of the remaining
+      # steps is to add a comment to the PR indicating that the actor (user) does
+      # NOT have permissions to run integration tests, and thus a maintainer must
+      # make sure the PR is "safe", and if so, re-run the "failed" integration tests
+      # (because maintainers DO have the necessary write permission).
+
+      - name: Download PR number artifact
         # The name of the output require-result is a bit confusing, but when its value
         # is 'false', it means that the triggering actor does NOT have the required
         # permission.
-        if: steps.permission.outputs.require-result == 'false'
+        if: ${{ !env.ACT && steps.permission.outputs.require-result == 'false' }}
+        uses: actions/github-script@v7
+        with:
+          # Download the PR artifact that was uploaded in integration-test.yml
+          script: |
+            const { owner, repo }  = context.repo;
+            const artifacts = await github.rest.actions.listWorkflowRunArtifacts({
+               owner, repo, run_id: context.payload.workflow_run.id,
+            });
+            const prNumberArtifact = artifacts.data.artifacts.filter(
+              (artifact) => artifact.name == "pr_number"
+            )[0];
+            const download = await github.rest.actions.downloadArtifact({
+               owner, repo, artifact_id: prNumberArtifact.id, archive_format: 'zip',
+            });
+
+            const fs = require('fs');
+            const path = require('path');
+            const temp = '${{ runner.temp }}/artifacts';
+
+            if (!fs.existsSync(temp)) {
+              fs.mkdirSync(temp);
+            }
+
+            fs.writeFileSync(path.join(temp, 'pr_number.zip'), Buffer.from(download.data));
+
+      - name: Unzip downloaded PR number artifact
+        if: ${{ !env.ACT && steps.permission.outputs.require-result == 'false' }}
+        run: unzip pr_number.zip -d "${{ runner.temp }}/artifacts"
+
+      - name: Add PR comment
+        # The name of the output require-result is a bit confusing, but when its value
+        # is 'false', it means that the triggering actor does NOT have the required
+        # permission.
+        if: ${{ !env.ACT && steps.permission.outputs.require-result == 'false' }}
 
         # If the triggering actor does not have write permission, then we want to add
         # a PR comment indicating a security review is required because we know that
         # the integration tests "failed" due to lack of permission (i.e., they were
         # actually "aborted" without running any tests).
         uses: actions/github-script@v7
         with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |
-            const { html_url } = await github.rest.issues.get({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              issue_number: context.issue.number,
-            });
+            const fs = require('fs');
+            const path = require('path');
+            const temp = '${{ runner.temp }}/artifacts';
+            const { owner, repo } = context.repo;
+
+            // Read the PR number from the downloaded and unzipped artifact.
+            const issue_number = Number(fs.readFileSync(path.join(temp, 'pr_number')));
+
+            // Get the URL of the PR so we can add a link in the PR comment.
+            const { html_url } = await github.rest.issues.get({ owner, repo, issue_number });
 
             github.rest.issues.createComment({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              issue_number: context.issue.number,
+              owner,
+              repo,
+              issue_number,
               body: "User [${{ github.triggering_actor }}](${{ github.event.workflow_run.head_repository.owner.html_url }})"
                 + " does not have permission to run integration tests. A maintainer must perform a security review of the"
                 + ` [code changes in this pull request](${html_url}/files) and re-run the`

.github/workflows/integration-test.yml

@@ -58,10 +58,39 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ["3.11", "3.12", "3.13"]
+        include:
+          - python-version: 3.11
+            # We must save the PR number only once, and this also prevents
+            # "duplicate artifact" errors caused when attempting to save the same
+            # artifact for every python version we're running with.  More specifically,
+            # save-pr-number must be set to 'true' for 1 (and only 1) matrix combo
+            # (it doesn't matter which combo).
+            save-pr-number: true
+          - python-version: 3.12
+            save-pr-number: false
+          - python-version: 3.13
+            save-pr-number: false
       fail-fast: false
 
     steps:
+      # The first 2 steps will save the PR number to a file and upload the file as an
+      # artifact, which we can then download if the workflow run fails (due to
+      # insufficient permissions), which is handled in integration-test-review.yml.
+      # See https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#using-data-from-the-triggering-workflow
+      - name: Save PR number
+        if: matrix.save-pr-number
+        env:
+          PR_NUMBER: ${{ github.event.number }}
+        run: |
+          mkdir -p ./pr
+          echo $PR_NUMBER > ./pr/pr_number
+
+      - uses: actions/upload-artifact@v4
+        if: matrix.save-pr-number
+        with:
+          path: pr/
+          name: pr_number
+
       - name: Fetch user permission
         if: github.event_name == 'pull_request_target'
         id: permission
@@ -127,4 +156,4 @@ jobs:
       - name: Upload coverage report
         # Don't upload coverage when using the `act` tool to run the workflow locally
         if: ${{ !env.ACT }}
-        uses: codecov/codecov-action@v4
+        uses: codecov/codecov-action@v5

.github/workflows/test-mindeps.yml

@@ -24,7 +24,7 @@ jobs:
         uses: actions/checkout@v4.1.1
 
       - name: Install uv
-        uses: astral-sh/setup-uv@v3.2.2
+        uses: astral-sh/setup-uv@v6.0.1
         with:
           enable-cache: true
 
@@ -42,4 +42,4 @@ jobs:
       - name: Upload coverage
         # Don't upload coverage when using the `act` tool to run the workflow locally
         if: ${{ !env.ACT }}
-        uses: codecov/codecov-action@v4
+        uses: codecov/codecov-action@v5

.github/workflows/test.yml

@@ -34,4 +34,4 @@ jobs:
       - name: Upload coverage
         # Don't upload coverage when using the `act` tool to run the workflow locally
         if: ${{ !env.ACT }}
-        uses: codecov/codecov-action@v4
+        uses: codecov/codecov-action@v5

.pre-commit-config.yaml

@@ -28,14 +28,14 @@ repos:
       - id: trailing-whitespace
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.11.4
+    rev: v0.11.8
     hooks:
       - id: ruff
         args: ["--fix", "--exit-non-zero-on-fix"]
       - id: ruff-format
 
   - repo: https://github.com/astral-sh/uv-pre-commit
-    rev: "0.6.13"
+    rev: "0.7.2"
     hooks:
       # Asserts that the lockfile is valid for pyproject.toml.
       # If it fails, update the lockfile by running:

CHANGELOG.md

@@ -20,6 +20,19 @@ and this project uses [Semantic Versioning](https://semver.org/spec/v2.0.0.html)
 ([#602](https://github.com/nsidc/earthaccess/issues/602))
 ([@rwegener2](https://github.com/rwegener2))
 
+### Changed
+
+- By default, _disable_ progress bars during downloading.
+  ([#612](https://github.com/nsidc/earthaccess/issues/612))
+  ([@Sherwin-14](https://github.com/Sherwin-14))
+
+### Fixed
+- Corrected Harmony typo in notebooks/Demo.ipynb([#995](https://github.com/nsidc/earthaccess/issues/995))([stelios-c](https://github.com/stelios-c))
+
+### Changed
+- Updated bug and triage label names in bug Issue template.
+  ([#998](https://github.com/nsidc/earthaccess/pull/998))
+  ([@asteiker](https://github.com/asteiker))
 
 ## [v0.14.0] - 2025-02-11
 

docs/quick-start.md

@@ -101,3 +101,6 @@ files = earthaccess.download(results, "./local_folder")
 
 Data can also be opened in-memory with `earthaccess.open()`. See [our API
 docs](user-reference/api/api.md) for more.
+
+
+We value your feedback! We want to hear all about your experience using earthaccess. Even if you're not noticing any issues or bugs, we want to know... what annoys you? What feels great? We'd love if you would share an experience [report](https://github.com/nsidc/earthaccess/issues/new/choose) with us!

earthaccess/store.py

@@ -73,6 +73,7 @@ def multi_thread_open(data: tuple[str, Optional[DataGranule]]) -> EarthAccessFil
     pqdm_kwargs = {
         "exception_behaviour": "immediate",
         "n_jobs": 8,
+        "disable": True,
         **(pqdm_kwargs or {}),
     }
 
@@ -529,6 +530,7 @@ def get(
 
         pqdm_kwargs = {
             "n_jobs": threads,
+            "disable": True,
             **(pqdm_kwargs or {}),
         }
 
@@ -738,6 +740,7 @@ def _download_onprem_granules(
 
         pqdm_kwargs = {
             "exception_behaviour": "immediate",
+            "disable": True,
             **(pqdm_kwargs or {}),
             # We don't want a user to be able to override the following kwargs,
             # which is why they appear *after* spreading pqdm_kwargs above.