Enabled ANN ruleset and fixed violations

Author: Sherwin-14

earthaccess/__init__.py

@@ -1,6 +1,6 @@
 import logging
 import threading
-from typing import Optional
+from typing import Optional, Any
 
 from .api import (
     auth_environ,
@@ -76,7 +76,7 @@
 _lock = threading.Lock()
 
 
-def __getattr__(name):  # type: ignore
+def __getattr__(name: str):  # noqa: ANN202
     """Module-level getattr to handle automatic authentication when accessing
     `earthaccess.__auth__` and `earthaccess.__store__`.
 

earthaccess/api.py

@@ -88,7 +88,7 @@ def _normalize_location(location: str | None) -> str | None:
     return location
 
 
-def search_datasets(count: int = -1, **kwargs: Any) -> list[DataCollection]:
+def search_datasets(count: int = -1, **kwargs: Any) -> list[DataCollection]:  # noqa: ANN401
     """Search datasets (collections) using NASA's CMR.
 
     [https://cmr.earthdata.nasa.gov/search/site/docs/search/api.html](https://cmr.earthdata.nasa.gov/search/site/docs/search/api.html)
@@ -186,7 +186,7 @@ def search_datasets(count: int = -1, **kwargs: Any) -> list[DataCollection]:
     return query.get_all()
 
 
-def search_data(count: int = -1, **kwargs: Any) -> list[DataGranule]:
+def search_data(count: int = -1, **kwargs: Any) -> list[DataGranule]:  # noqa: ANN401
     """Search for dataset files (granules) using NASA's CMR.
 
     [https://cmr.earthdata.nasa.gov/search/site/docs/search/api.html](https://cmr.earthdata.nasa.gov/search/site/docs/search/api.html)
@@ -280,7 +280,7 @@ def search_data(count: int = -1, **kwargs: Any) -> list[DataGranule]:
     return query.get_all()
 
 
-def search_services(count: int = -1, **kwargs: Any) -> list[Any]:
+def search_services(count: int = -1, **kwargs: Any) -> list[Any]:  # noqa: ANN401
     """Search the NASA CMR for Services matching criteria.
 
     See <https://cmr.earthdata.nasa.gov/search/site/docs/search/api.html#service>.

earthaccess/auth.py

@@ -57,7 +57,7 @@ def __init__(self, hostname: str, auth: tuple[str, str]) -> None:
         self.hostname = hostname
         self.auth = auth
 
-    def __call__(self, r: requests.Response, **kwargs: Any) -> requests.Response:
+    def __call__(self, r: requests.Response, **kwargs: Any) -> requests.Response:  # noqa: ANN401
 
         # If the response's URL is not for the EDL system we're authenticating
         # against, then simply return the response unchanged.  Otherwise, we'll
@@ -113,7 +113,7 @@ def login(
         strategy: str = "netrc",
         persist: bool = False,  # noqa: FBT001, FBT002
         system: System | None = None,
-    ) -> Any:
+    ) -> Any:  # noqa: ANN401
         """Authenticate with Earthdata login.
 
         Parameters:

earthaccess/formatters.py

@@ -18,7 +18,7 @@ def _repr_collection_html() -> str:
     return "<div></div>"
 
 
-def _repr_granule_html(granule: Any) -> str:
+def _repr_granule_html(granule: Any) -> str:  # noqa: ANN401
     css_styles = _load_static_files()
     css_inline = f"""<div id="{uuid4()}" style="height: 0px; display: none">
             {"".join([f"<style>{style}</style>" for style in css_styles])}

earthaccess/results.py

@@ -31,7 +31,7 @@ def __init__(
         collection: dict[str, Any],
         fields: list[str] | None = None,
         cloud_hosted: bool = False,  # noqa: FBT001, FBT002
-    ):
+    ) -> None:
         super().__init__(collection)
         self.cloud_hosted = cloud_hosted
         self.uuid = str(uuid.uuid4())
@@ -341,7 +341,7 @@ def __init__(
         collection: dict[str, Any],
         fields: list[str] | None = None,
         cloud_hosted: bool = False,  # noqa: FBT001, FBT002
-    ):
+    ) -> None:
         super().__init__(collection)
         self.cloud_hosted = cloud_hosted
         # TODO: maybe add area, start date and all that as an instance value

earthaccess/search.py

@@ -36,7 +36,7 @@ class DataCollections(CollectionQuery):
     _fields: list[str] | None = None
     _format = "umm_json"
 
-    def __init__(self, auth: Auth | None = None, *args: Any, **kwargs: Any) -> None:
+    def __init__(self, auth: Auth | None = None, *args: Any, **kwargs: Any) -> None:  # noqa: ANN401
         """Builds an instance of DataCollections to query the CMR.
 
         Parameters:
@@ -426,7 +426,7 @@ class DataGranules(GranuleQuery):
 
     _format = "umm_json"
 
-    def __init__(self, auth: Auth | None = None, *args: Any, **kwargs: Any) -> None:
+    def __init__(self, auth: Auth | None = None, *args: Any, **kwargs: Any) -> None:  # noqa: ANN401
         super().__init__(*args, **kwargs)
 
         self.session = (
@@ -749,7 +749,7 @@ def _valid_state(self) -> bool:
             key in self.params for key in collection_keys
         )
 
-    def _is_cloud_hosted(self, granule: Any) -> bool:
+    def _is_cloud_hosted(self, granule: Any) -> bool:  # noqa: ANN401
         """Check if a granule record, from CMR, advertises "direct access"."""
         if "RelatedUrls" not in granule["umm"]:
             return False

earthaccess/services.py

@@ -16,7 +16,7 @@ class DataServices(ServiceQuery):
 
     _format = "umm_json"
 
-    def __init__(self, auth: Auth | None = None, *args: Any, **kwargs: Any) -> None:
+    def __init__(self, auth: Auth | None = None, *args: Any, **kwargs: Any) -> None:  # noqa: ANN401
         """Build an instance of DataService to query CMR.
 
         auth is an optional parameter for queries that need authentication,

earthaccess/store.py

@@ -85,7 +85,7 @@ def __init__(
         self.f = f
         self.granule = granule
 
-    def __getattribute__(self, name: str) -> Any:
+    def __getattribute__(self, name: str) -> Any:  # noqa: ANN401
         # use super().__getattribute__ to avoid infinite recursion
         if (name in EarthAccessFile.__dict__) or (name in self.__dict__):
             # accessing our attributes
@@ -94,7 +94,7 @@ def __getattribute__(self, name: str) -> Any:
         proxy = super().__getattribute__("f")
         return getattr(proxy, name)
 
-    def __reduce_ex__(self, protocol: Any) -> Any:
+    def __reduce_ex__(self, protocol: Any) -> Any:  # noqa: ANN401
         return make_instance, (
             self.__class__,
             self.granule,
@@ -163,10 +163,10 @@ def multi_thread_open(data: tuple[str, DataGranule | None]) -> EarthAccessFile:
 
 
 def make_instance(
-    cls: Any,
+    cls: Any,  # noqa: ANN401
     granule: DataGranule,
     auth: Auth,
-    data: Any,
+    data: Any,  # noqa: ANN401
 ) -> EarthAccessFile:
     # Attempt to re-authenticate
     if not earthaccess.__auth__.authenticated:
@@ -236,7 +236,7 @@ def _sibling_tempfile(sibling: Path) -> Generator[Path, None, None]:
 class Store:
     """Store class to access granules on-prem or in the cloud."""
 
-    def __init__(self, auth: Any, pre_authorize: bool = False) -> None:  # noqa: FBT001, FBT002
+    def __init__(self, auth: Any, pre_authorize: bool = False) -> None:  # noqa: FBT001, FBT002, ANN401
         """Store is the class to access data.
 
         Parameters:

earthaccess/utils/_validation.py

@@ -1,5 +1,5 @@
 from typing import Any
 
 
-def valid_dataset_parameters(**kwargs: Any) -> bool:
+def valid_dataset_parameters(**kwargs: Any) -> bool:  # noqa: ANN401
     return len(kwargs) != 0

earthaccess/virtual/_parser.py

@@ -43,7 +43,7 @@
 def resolve_parser(
     parser: ParserType,
     group: str | None = None,
-) -> Any:
+) -> Any:  # noqa: ANN401
     """Resolve a parser name or instance to a VirtualiZarr parser object.
 
     If ``parser`` is already an instance (i.e. not a ``str``) it is returned
@@ -106,7 +106,7 @@ def resolve_parser(
 
 def get_urls_for_parser(
     granules: list[earthaccess.DataGranule],
-    parser: Any,
+    parser: Any,  # noqa: ANN401
     access: AccessType,
 ) -> list[str]:
     """Return one data URL per granule, formatted for the given parser.