WGPS progress tracking#35
Open
xash wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Ah, that also fixes #26 I think. |
sgwilym
requested changes
Nov 22, 2024
Contributor
sgwilym
left a comment
sgwilym
left a comment
There was a problem hiding this comment.
Fantastic, only a few nitpicks!
| constructor(todo: number, all: number) { | ||
| super("status", { | ||
| detail: { | ||
| todo, |
Contributor
There was a problem hiding this comment.
Nitpick: could we change this to remaining, as at least for me todo triggers thoughts of 'oh, I guess this is something someone forgot to do'?
| private count = 0n; | ||
| private inProgress = new Set<bigint>(); | ||
|
|
||
| constructor() {} |
| return newStore; | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Thank you so much for making these tests better.
Fixes also a bug where a received ReconciliationAnnounceEntries message with wantResponse = true did not increase your_range_counter.
Currently the status will indicate done even when some entries are yet to be processed, e.g. storing them. That's why there is still a small(er) delay.
Contributor
Author
|
Done :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks range counters on both sides. WGPS emits a StatusEvent with simple { todo: number, all: number } info. This is now also used in some tests where reconciliation is expected, to lower the delay. { todo: 0 } could still have some unprocessed entries in some store promise, so still little delay is needed for now.