Skip to content

add custom easyblock for BLIS#3385

Closed
wwweert123 wants to merge 9 commits into
easybuilders:developfrom
wwweert123:20240708112836_new_pr_blis
Closed

add custom easyblock for BLIS#3385
wwweert123 wants to merge 9 commits into
easybuilders:developfrom
wwweert123:20240708112836_new_pr_blis

Conversation

@wwweert123
Copy link
Copy Markdown

(created using eb --new-pr)

@wwweert123
Copy link
Copy Markdown
Author

https://github.com/EESSI/software-layer/blob/f64a20d373a3047a55315a92401c0610bf526844/eb_hooks.py#L343-L358 This easyblock for BLIS was implemented to also take into account building on A64FX cpu architecture where additional configure opts are needed.

@boegel boegel added the new label Jul 31, 2024
@boegel boegel added this to the release after 4.9.2 milestone Jul 31, 2024
@boegel boegel changed the title new easyblock for blis add custom easyblock for BLIS Jul 31, 2024
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution @wwweert123!

Do you mind also opening a companion PR for the recent BLIS easyconfigs, so clean them up so the custom easyblock for BLIS is being used?

Of course we'll make sure that this PR gets merged first...

Comment thread easybuild/easyblocks/b/blis.py Outdated
@wwweert123
Copy link
Copy Markdown
Author

Thanks a lot for the contribution @wwweert123!

Do you mind also opening a companion PR for the recent BLIS easyconfigs, so clean them up so the custom easyblock for BLIS is being used?

Of course we'll make sure that this PR gets merged first...

Oh yes, I have created a companion PR BLIS easyconfig that makes use of this custom easyblock. I had forgotten to mention it here in this PR.

easybuilders/easybuild-easyconfigs#20973

wwweert123 and others added 2 commits July 31, 2024 22:16
@boegel boegel modified the milestones: 4.9.3, release after 4.9.3 Sep 11, 2024
@boegel boegel modified the milestones: release after 4.9.4, release after 5.0.0 Mar 18, 2025
@boegel boegel modified the milestones: next release (5.1.0), 5.x May 22, 2025
@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Jul 1, 2025

This is probably not required anymore since #3773 is merged, right?

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 2, 2025

Yeah, this has bit-rotted a bit unfortunately...

Maybe @smoors can take a look if there's anything in here that should be ported over to the custom easyblock for BLIS that got merged via #3773 (and if not, close this)

@Crivella
Copy link
Copy Markdown
Contributor

Crivella commented Sep 4, 2025

Beside minor differences in the behavior of the EConfing extra parameters the other relevant difference would be for a64fx

        # arch_name will only be available when archspec is available to easybuild, else arch_name will be unknown
        arch_name = get_cpu_arch_name()
        if arch_name == "a64fx":
            self.cfg.update('configopts', 'CFLAGS="$CFLAGS -DCACHE_SECTOR_SIZE_READONLY"')

which we are not passing

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 10, 2025

Beside minor differences in the behavior of the EConfing extra parameters the other relevant difference would be for a64fx

        # arch_name will only be available when archspec is available to easybuild, else arch_name will be unknown
        arch_name = get_cpu_arch_name()
        if arch_name == "a64fx":
            self.cfg.update('configopts', 'CFLAGS="$CFLAGS -DCACHE_SECTOR_SIZE_READONLY"')

which we are not passing

That would definitely be helpful to have, since in EESSI we now deal with this in a hook:

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 10, 2025

@smoors Can you take a look at a follow-up PR for the BLIS easyblock that applies the additional things that were done in this PR but not in your merged PR #3773 ?

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Sep 20, 2025

@smoors Can you take a look at a follow-up PR for the BLIS easyblock that applies the additional things that were done in this PR but not in your merged PR #3773 ?

done in #3938

@smoors smoors closed this Sep 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants