enhance JuliaPackage easyblock to avoid writing to $HOME & clean up JuliaBundle#4102
enhance JuliaPackage easyblock to avoid writing to $HOME & clean up JuliaBundle#4102Flamefire wants to merge 12 commits into
JuliaPackage easyblock to avoid writing to $HOME & clean up JuliaBundle#4102Conversation
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 3 (total: 1 hour 12 mins 55 secs) (3 easyconfigs in total) |
|
The only failure above is from a test failing due to German locale: "Warnung != Warning" |
JuliaPackage easyblock to avoid writing to $HOME & clean up JuliaBundle
|
@lexming Can you take a look at this? |
|
@boegelbot please test @ jsc-zen3 |
08a7ece to
7cf6413
Compare
|
Can confirm that with this PR neither Test report by @Crivella Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (total: 10 mins 0 secs) (1 easyconfigs in total) |
|
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 4345043665 processed Message to humans: this is just bookkeeping information for me, |
|
I'm currently invetigating why the sanity check of |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 8 (total: 1 hour 14 mins 49 secs) (8 easyconfigs in total) |
|
Test report by @Crivella Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (total: 9 mins 5 secs) (1 easyconfigs in total) |
Co-authored-by: Davide Grassano <34096612+Crivella@users.noreply.github.com>
That one is very weird: Looks like something else is off, seen that before when doing testing, but it disappeared. And now it's back again. |
I assume it is coming from some extra stuff you have in framework (eg maybe you are on top of easybuilders/easybuild-framework#5185 ?) I tested one of them on my workstation with develop as the framework branch and it works normally |
|
In |
|
True, I'm trying to always use all my open PRs in one tree for all builds so I detect issues. So indeed that PR was the cause: In some intermediate version I had an inverted condition in this (now fixed up) commit easybuilders/easybuild-framework@5ace95d The job must have started before I applied that fix back on the cluster |
|
@boegelbot please test @ jsc-zen3 |
|
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 4358702055 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 7 out of 8 (total: 1 hour 13 mins 11 secs) (8 easyconfigs in total) |
That is caused by not listing all required packages, so an actual bug in the easyconfig we didn't catch before setting "offline" in the sanity check and hence the missing package was downloaded. |
|
We could probably also double check the other ECs with NOTE: It seems that I am wondering if we should allow downloads for testing, right now we would need to install the test dependencies together with the normal ones. In this case |
1b06f4e to
125342a
Compare
Fix in easybuilders/easybuild-easyconfigs#25903
As a good proxy we can run them as test reports for this PR. If the (now offline) sanity checks succeed there is a high chance they are complete.
If I understand the code directly it is not only for testing but an optional dependency allowing additional features. When they are not used nothing breaks. Only the tests assume they are available. Enabling downloads wouldn't be a good solution IMO. We already spend quite some time elsewhere in EasyBuild to allow fully offline builds. |
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 13 out of 14 (total: 4 hours 17 mins 16 secs) (13 easyconfigs in total) |
|
Added a fix in easybuilders/easybuild-easyconfigs#25909 that avoids the writes to $HOME in the sanity check. |
|
@boegelbot please test @ jsc-zen3 |
|
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 4377729904 processed Message to humans: this is just bookkeeping information for me, |
This begs the question if we should always set |
This fits into the discussion of setting Python and Cargo variables in framework where the same applies |
(created using
eb --new-pr)Some easyconfigs have sanity check commands that run e.g.
julia -e ...This will use the
$JULIA_DEPOT_PATHset in the module which is something like:/foo:/barwhere the leading colon means "including the user depot": https://docs.julialang.org/en/v1/manual/environment-variables/#JULIA_DEPOT_PATHThat will write artifacts/cache files to
$HOME/.juliaor fail if that's not writable.Similar to PythonPackage/PythonBundle use a temporary directory for that and end with a trailing colon for "excluding the user depot."
Additionally some empty methods on Juliabundle can be removed