Be more careful on mistaking extension for extra_modules in _sanity_check_step

Author: Flamefire

easybuild/framework/easyblock.py

@@ -4391,6 +4391,11 @@ def _sanity_check_step(self, custom_paths=None, custom_commands=None, extra_modu
         :param extension: indicates whether or not sanity check is run for an extension
         :param extra_modules: extra modules to load before running sanity check commands
         """
+        if extra_modules is not None and not isinstance(extra_modules, list):
+            if isinstance(extra_modules, bool):
+                self.log.nosupport("Do not pass `extension` to `_sanity_check_step`", '5.3.1')
+            raise EasyBuildError("extra_modules should be a list of module names, got %s (type: %s)",
+                                 extra_modules, type(extra_modules))
         paths, path_keys_and_check, commands = self._sanity_check_step_common(custom_paths, custom_commands)
 
         # helper function to sanity check (alternatives for) one particular path