Skip to content

Improve --bwrap to work with r/o filesystems (overlayfs) and --subdir-{modules,software}#5173

Merged
smoors merged 6 commits into
easybuilders:developfrom
bartoldeman:bwrap-improved
Jun 29, 2026
Merged

Improve --bwrap to work with r/o filesystems (overlayfs) and --subdir-{modules,software}#5173
smoors merged 6 commits into
easybuilders:developfrom
bartoldeman:bwrap-improved

Conversation

@bartoldeman

@bartoldeman bartoldeman commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Two changes to make --bwrap work for our situation:

  • use --subdir-{modules,software}: this makes the paths more similar under the bwrap installdir if you use those.
  • use overlayfs, but only if we can't create the external installdir.

@bartoldeman
Use subdir_software/subdir_modules for --bwrap
bc88860 
Using those instead of hardcoded 'software' and 'modules' makes
the path inside the bwrap installdir more similar to the external
paths, if --subdir-software or --subdir-modules are used.
@bartoldeman
Use overlayfs with bwrap if we cannot create installdir
4d8e6a4 
In that case we go up the directory tree until we find a
directory that exists, and use overlayfs to avoid hiding
the other directories (that could have dependent software!)
bartoldeman added a commit to ComputeCanada/gentoo-overlay that referenced this pull request Apr 13, 2026
@bartoldeman
EasyBuild framework: add patch for improved bwrap support
b1b7674 
Upstream PR easybuilders/easybuild-framework#5173
bartoldeman added a commit to ComputeCanada/easybuild-computecanada-config that referenced this pull request Apr 13, 2026
@bartoldeman
Use upstream --bwrap functionality
356341f 
Using EB 5.3.0 + easybuilders/easybuild-framework#5173
This also improves diagnostics a bit, with the name of the tarball at
the tail end of the screen output.
@smoors

smoors commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

tested without overlay, works well

@smoors

smoors commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

for adding a test for the overlay feature, you could add this to .github/workflows/end2end_bwrap.yml once ubuntu 26.04 comes out (expected in a week), which will have bubblewrap 0.11

@smoors

smoors commented Apr 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@bartoldeman with the support for --subdir-{modules,software}, could you also add bwrap_installpath_software and bwrap_installpath_modules to the bwrap_info.json file?

it's not really needed because all the needed info is already present, but it will make it easier to use the json file for copying the files to their final destination after the installation.

EDIT: implemented in cd0267c.

@smoors

smoors commented Jun 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@bartoldeman i've added an end-to-end test for bwrap with overlay on ubuntu 26.04
the tests will however fail until easybuilders/easybuild-easyconfigs#26258 is merged

(well, they didn't fail because i added a --try-amend option, but that should be removed afterward).

edit: fix merged and --try-amend removed

smoors
smoors approved these changes Jun 29, 2026
View reviewed changes

@smoors smoors left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added this to the next release (5.3.2?) milestone Jun 29, 2026
@smoors smoors merged commit 4f19fd8 into easybuilders:develop Jun 29, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

next release (5.3.2?)

Development

Successfully merging this pull request may close these issues.

2 participants

@bartoldeman @smoors