Device definitions available as patch releases (#19)#20
Conversation
- Switches automatic version bump from minor to patch - Updated Readme file with compatible release operator sample
|
Thanks. I've given this a bit more thought, and how about this - I'll update the major version if there are breaking changes, and the minor version if there are simple code changes, and the patch version for device database changes. So people can depend on the minor version if they want updated code changes (non-breaking) along with device updates. If they rely on the patch version, then they'll get device DB updates until the next set of non-breaking code changes. Otherwise this will force me to make every non-breaking code change (or internal refactor) a patch update, which is semantically wrong. And the major version will be quite pointless then, since it'll never increment. Curious to know your thoughts. Thanks |
|
Sounds fine. I'll update the Readme text. |
|
Just to confirm, running |
|
Hi @iwr-redmond I've replied in the original issue, and pushed the changes for this (and updated the readme). https://github.com/easydiffusion/torchruntime#versioning-scheme
Maybe my understanding is incorrect, but wouldn't that only result in Closing this PR since the original purpose has been resolved. |
|
Thanks a lot for bringing this up, and for your help! :) |
Resolves: #19