fixes with printing

Author: strengejacke

DESCRIPTION

@@ -1,7 +1,7 @@
 Type: Package
 Package: modelbased
 Title: Estimation of Model-Based Predictions, Contrasts and Means
-Version: 0.14.0.4
+Version: 0.14.0.5
 Authors@R:
     c(person(given = "Dominique",
              family = "Makowski",

R/format.R

@@ -16,7 +16,7 @@ format.estimate_contrasts <- function(
   }
   # change parameter name for context effects
   if (isTRUE(attributes(x)$context_effects)) {
-    x$Parameter <- "Average slope"
+    x$Parameter <- NULL
   }
 
   # don't print columns of adjusted_for variables
@@ -174,7 +174,14 @@ format.marginaleffects_means <- function(x, model, ci = 0.95, ...) {
     )
     # for inequality analysis, we want to keep the stratification variable
     remove_columns <- setdiff(remove_columns, attributes(x)$hypothesis_by)
-  } else if (is_contrast_analysis || context_effects) {
+  } else if (context_effects) {
+    # for contrasting average slopes (context effects), the estimate might be
+    # an odds ratio or IRR by default - thus, we want to keep those names
+    estimate_name <- .guess_estimate_name(predict_type, transform, info)
+    if (identical(estimate_name, "Mean")) {
+      estimate_name <- "Difference"
+    }
+  } else if (is_contrast_analysis) {
     estimate_name <- "Difference"
   } else {
     # for simple means, we don't want p-values

R/table_footer.R

@@ -117,14 +117,23 @@
       `invlink(link)` = "response",
       predict
     )
-    table_footer <- paste0(
-      table_footer,
-      "\n",
-      result_type,
-      " are on the ",
-      predict,
-      "-scale."
-    )
+    # we may have link-scale and transformation. to avoid confusion, tell this
+    # here
+    if (predict == "link" && !is.null(transform)) {
+      predict <- paste0(transform, "-transformed ", predict)
+    }
+    # if we have contrasts of slope for GLMs, the default is to calculate
+    # ORs or IRRs - in this case, we don't add information about the scale
+    if (!any(c("Odds_Ratio", "IRR") %in% colnames(x))) {
+      table_footer <- paste0(
+        table_footer,
+        "\n",
+        result_type,
+        " are on the ",
+        predict,
+        "-scale."
+      )
+    }
   } else if (isTRUE(model_info$is_linear) && !isTRUE(transform)) {
     # add information about response transformation
     trans_fun <- .safe(insight::find_transformation(model))

tests/testthat/test-estimate_contrasts_context.R

@@ -12,14 +12,17 @@ test_that("estimate_contrast, context effects, linear", {
   b <- coef(summary(m))[2:3, 1]
   se <- coef(summary(m))[2:3, 2]
 
-  out <- modelbased::estimate_contrasts(
+  out <- estimate_contrasts(
     m,
     c("bill_len_between", "bill_len_within"),
     comparison = "context"
   )
-  expect_equal(out$Mean, b[1] - b[2], tolerance = 1e-4, ignore_attr = TRUE)
+  expect_equal(out$Difference, b[1] - b[2], tolerance = 1e-4, ignore_attr = TRUE)
   expect_equal(out$SE, sqrt((se[1]^2 + se[2]^2)), tolerance = 1e-4, ignore_attr = TRUE)
   expect_true(!is.null(out$p))
+
+  output <- capture.output(out)
+  expect_identical(output[3], "Difference |   SE |         95% CI |      z |      p")
 })
 
 test_that("estimate_contrast, context effects, glm", {
@@ -31,23 +34,26 @@ test_that("estimate_contrast, context effects, glm", {
   b <- coef(summary(m))[2:3, 1]
   se <- coef(summary(m))[2:3, 2]
 
-  out <- modelbased::estimate_contrasts(
+  out <- estimate_contrasts(
     m,
     c("bill_len_between", "bill_len_within"),
     comparison = "context"
   )
   expect_equal(out$Odds_Ratio, exp(b[1] - b[2]), tolerance = 1e-4, ignore_attr = TRUE)
   expect_true(!is.null(out$p))
 
-  out <- modelbased::estimate_contrasts(
+  output <- capture.output(out)
+  expect_identical(output[3], "Odds_Ratio |       95% CI |     p")
+
+  out <- estimate_contrasts(
     m,
     c("bill_len_between", "bill_len_within"),
     comparison = "slope"
   )
   expect_equal(out$Odds_Ratio, exp(b[1] - b[2]), tolerance = 1e-4, ignore_attr = TRUE)
   expect_true(!is.null(out$p))
 
-  out <- modelbased::estimate_contrasts(
+  out <- estimate_contrasts(
     m,
     c("bill_len_between", "bill_len_within"),
     comparison = "context",