-
-
Notifications
You must be signed in to change notification settings - Fork 23
Add validation to ensure es_type parameter is only used with effectsize = "boot"
#577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
43ef485
cafab50
cc1e795
fbebfd3
d273af4
e73655e
68d30a6
63a6934
f9d311b
f2ba8b3
5ff532c
db77b9b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -317,6 +317,17 @@ estimate_contrasts.default <- function( | |||||||||||||||||||||||
| # validate input | ||||||||||||||||||||||||
| estimate <- .validate_estimate_arg(estimate) | ||||||||||||||||||||||||
| comparison <- .check_for_inequality_comparison(comparison) | ||||||||||||||||||||||||
| # Validate es_type usage | ||||||||||||||||||||||||
| call_args <- match.call() | ||||||||||||||||||||||||
| if ("es_type" %in% names(call_args)) { | ||||||||||||||||||||||||
| if (is.null(effectsize)) { | ||||||||||||||||||||||||
| insight::format_error( | ||||||||||||||||||||||||
| "`es_type` can only be used when `effectsize` is specified. Currently `effectsize = NULL`." | ||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||
| } else if (effectsize != "boot") { | ||||||||||||||||||||||||
| insight::format_error("`es_type` can only be used when `effectsize = \"boot\"`.") | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should move these checks into the function that computes the effect sizes,
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. But then we have a minor problem with the default modelbased/R/estimate_contrasts.R Lines 366 to 376 in f2ba8b3
There's another area of confusion. If people are not allowed to manually specify |
||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| if (backend == "emmeans") { | ||||||||||||||||||||||||
| # Emmeans ---------------------------------------------------------------- | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.