Skip to content

Commit bd8786c

Browse files
Python: correct Azure integration env mapping
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent feb4bd7 commit bd8786c

4 files changed

Lines changed: 10 additions & 4 deletions

File tree

.github/workflows/python-integration-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ jobs:
9696
environment: integration
9797
timeout-minutes: 60
9898
env:
99-
AZURE_OPENAI_CHAT_DEPLOYMENT_NAME: ${{ vars.AZUREOPENAI__RESPONSESDEPLOYMENTNAME }}
99+
AZURE_OPENAI_CHAT_DEPLOYMENT_NAME: ${{ vars.AZUREOPENAI__CHATDEPLOYMENTNAME }}
100100
AZURE_OPENAI_RESPONSES_DEPLOYMENT_NAME: ${{ vars.AZUREOPENAI__RESPONSESDEPLOYMENTNAME }}
101101
AZURE_OPENAI_DEPLOYMENT_NAME: ${{ vars.AZUREOPENAI__RESPONSESDEPLOYMENTNAME }}
102102
AZURE_OPENAI_EMBEDDING_DEPLOYMENT_NAME: ${{ vars.AZUREOPENAI__EMBEDDINGDEPLOYMENTNAME }}

.github/workflows/python-merge-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ jobs:
195195
runs-on: ubuntu-latest
196196
environment: integration
197197
env:
198-
AZURE_OPENAI_CHAT_DEPLOYMENT_NAME: ${{ vars.AZUREOPENAI__RESPONSESDEPLOYMENTNAME }}
198+
AZURE_OPENAI_CHAT_DEPLOYMENT_NAME: ${{ vars.AZUREOPENAI__CHATDEPLOYMENTNAME }}
199199
AZURE_OPENAI_RESPONSES_DEPLOYMENT_NAME: ${{ vars.AZUREOPENAI__RESPONSESDEPLOYMENTNAME }}
200200
AZURE_OPENAI_DEPLOYMENT_NAME: ${{ vars.AZUREOPENAI__RESPONSESDEPLOYMENTNAME }}
201201
AZURE_OPENAI_EMBEDDING_DEPLOYMENT_NAME: ${{ vars.AZUREOPENAI__EMBEDDINGDEPLOYMENTNAME }}

python/packages/azure-ai/tests/azure_openai/test_azure_embedding_client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,10 @@ def test_azure_otel_provider_name(azure_embedding_unit_test_env: None) -> None:
108108

109109
skip_if_azure_openai_integration_tests_disabled = pytest.mark.skipif(
110110
os.getenv("AZURE_OPENAI_ENDPOINT", "") in ("", "https://test-endpoint.com")
111-
or os.getenv("AZURE_OPENAI_EMBEDDING_DEPLOYMENT_NAME", "") == "",
111+
or (
112+
os.getenv("AZURE_OPENAI_EMBEDDING_DEPLOYMENT_NAME", "") == ""
113+
and os.getenv("AZURE_OPENAI_DEPLOYMENT_NAME", "") == ""
114+
),
112115
reason="No Azure OpenAI endpoint or embedding deployment provided; skipping integration tests.",
113116
)
114117

python/packages/openai/tests/openai/test_openai_embedding_client_azure.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,10 @@
1717

1818
skip_if_azure_openai_integration_tests_disabled = pytest.mark.skipif(
1919
os.getenv("AZURE_OPENAI_ENDPOINT", "") in ("", "https://test-endpoint.openai.azure.com")
20-
or os.getenv("AZURE_OPENAI_EMBEDDING_DEPLOYMENT_NAME", "") == "",
20+
or (
21+
os.getenv("AZURE_OPENAI_EMBEDDING_DEPLOYMENT_NAME", "") == ""
22+
and os.getenv("AZURE_OPENAI_DEPLOYMENT_NAME", "") == ""
23+
),
2124
reason="No real Azure OpenAI endpoint or embedding deployment provided; skipping integration tests.",
2225
)
2326

0 commit comments

Comments
 (0)