Correction FSBL and remove action pythohn3.8

Author: ebachelet

.github/workflows/actions_unit_tests.yaml

@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [ "3.8", "3.9", "3.10", "3.11" ]
+        python-version: [ "3.9", "3.10", "3.11" ]
 
     steps:
       - uses: actions/checkout@v3

pyLIMA/magnification/magnification_VBB.py

@@ -135,8 +135,10 @@ def magnification_FSBL(separation, mass_ratio, x_source, y_source, rho,
     for xs, ys, s in zip(x_source, y_source, separation):
         #magnification_VBB = VBB.BinaryMagDark(s, mass_ratio, xs, ys, rho,
         #                                      limb_darkening_coefficient)
-        magnification_VBB = VBM.BinaryMagDark(s, mass_ratio, xs, ys, rho,
-                                              limb_darkening_coefficient)
+        #magnification_VBB = VBM.BinaryMagDark(s, mass_ratio, xs, ys, rho,
+        #                                      limb_darkening_coefficient)
+        VBM.a1 = limb_darkening_coefficient
+        magnification_VBB = VBM.BinaryMag2(s, mass_ratio, xs, ys, rho)
 
         magnification_fsbl.append(magnification_VBB)
 

pyLIMA/stars/__init__.py

@@ -0,0 +1 @@
+__all__ = ["Star"]

pyLIMA/tests/test_magnification.py

@@ -162,7 +162,7 @@ def test_magnification_FSBL():
                                                          x_source, y_source, rho,
                                                          limb_darkening_coefficient)
 
-    assert np.allclose(magnification[0],4.39589349809541)
+    assert np.allclose(magnification[0],4.396361656443572)
 
 
 def test_magnification_PSBL():

pyLIMA/tests/test_model.py

@@ -234,7 +234,8 @@ def test_FSBL():
 
     pym = Model.compute_pyLIMA_parameters(params)
     magi = Model.model_magnification(event.telescopes[0], pym)
-    assert np.allclose(magi, [4.73518855, 2.32967011])
+
+    assert np.allclose(magi, [4.73316752, 2.32814229])
 
 
 def test_FSPL():
@@ -259,7 +260,7 @@ def test_FSPLarge():
     pym = Model.compute_pyLIMA_parameters(params)
     magi = Model.model_magnification(event.telescopes[0], pym)
 
-    assert np.allclose(magi, [1.05837633, 1.05730364])
+    assert np.allclose(magi, [1.05906354, 1.05890356])
 
 
 def test_PSBL():
@@ -312,7 +313,7 @@ def test_USBL():
     pym = Model.compute_pyLIMA_parameters(params)
     magi = Model.model_magnification(event.telescopes[0], pym)
 
-    assert np.allclose(magi, [73.75028234, 2.12549786])
+    assert np.allclose(magi, [74.02173897,  2.12621654])
 
     event = _create_event()
 
@@ -321,4 +322,4 @@ def test_USBL():
     pym = Model.compute_pyLIMA_parameters(params)
     magi = Model.model_magnification(event.telescopes[0], pym)
 
-    assert np.allclose(magi, [76.16515049, 2.11882843])
+    assert np.allclose(magi, [76.32960572,  2.11953819])