Skip to content
This repository was archived by the owner on Oct 22, 2020. It is now read-only.

Commit 44d013e

Browse files
committed
Remove all use of import static
1 parent 990bb47 commit 44d013e

4 files changed

Lines changed: 23 additions & 40 deletions

File tree

src/main/java/io/ebean/querybean/generator/FindDbName.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
import java.util.Map;
1212
import java.util.Set;
1313

14-
import static io.ebean.querybean.generator.Constants.DBNAME;
15-
1614
class FindDbName {
1715

1816
/**
@@ -48,7 +46,7 @@ private static AnnotationMirror findDbNameMirror(TypeElement element) {
4846
final List<? extends AnnotationMirror> mirrors = element.getAnnotationMirrors();
4947
for (AnnotationMirror mirror : mirrors) {
5048
final String name = mirror.getAnnotationType().asElement().toString();
51-
if (DBNAME.equals(name)) {
49+
if (Constants.DBNAME.equals(name)) {
5250
return mirror;
5351
}
5452
}

src/main/java/io/ebean/querybean/generator/ProcessingContext.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import javax.tools.Diagnostic;
2424
import javax.tools.FileObject;
2525
import javax.tools.JavaFileObject;
26+
import javax.tools.StandardLocation;
2627
import java.io.FileNotFoundException;
2728
import java.io.IOException;
2829
import java.io.LineNumberReader;
@@ -36,8 +37,6 @@
3637
import java.util.TreeMap;
3738
import java.util.TreeSet;
3839

39-
import static javax.tools.StandardLocation.CLASS_OUTPUT;
40-
4140
/**
4241
* Context for the source generation.
4342
*/
@@ -465,7 +464,7 @@ FileObject createManifestWriter() throws IOException {
465464
}
466465

467466
FileObject createMetaInfWriter(String target) throws IOException {
468-
return filer.createResource(CLASS_OUTPUT, "", target);
467+
return filer.createResource(StandardLocation.CLASS_OUTPUT, "", target);
469468
}
470469

471470
Set<String> getPrefixEntities() {
@@ -495,7 +494,7 @@ String getFactoryPackage() {
495494
*/
496495
String loadMetaInfServices() {
497496
try {
498-
FileObject fileObject = processingEnv.getFiler().getResource(CLASS_OUTPUT, "", METAINF_SERVICES_MODULELOADER);
497+
FileObject fileObject = processingEnv.getFiler().getResource(StandardLocation.CLASS_OUTPUT, "", METAINF_SERVICES_MODULELOADER);
499498
if (fileObject != null) {
500499
Reader reader = fileObject.openReader(true);
501500
LineNumberReader lineReader = new LineNumberReader(reader);

src/main/java/io/ebean/querybean/generator/ReadModuleInfo.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
import java.util.Map;
1010
import java.util.Set;
1111

12-
import static io.ebean.querybean.generator.Constants.MODULEINFO;
13-
1412
/**
1513
* Helper to read the current/existing prefixed entity classes.
1614
* <p>
@@ -30,7 +28,7 @@ List<String> read(Element element) {
3028

3129
for (AnnotationMirror mirror : mirrors) {
3230
final String name = mirror.getAnnotationType().asElement().toString();
33-
if (MODULEINFO.equals(name)) {
31+
if (Constants.MODULEINFO.equals(name)) {
3432
return readEntities(mirror);
3533
}
3634
}

src/main/java/io/ebean/querybean/generator/SimpleQueryBeanWriter.java

Lines changed: 18 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,6 @@
1313
import java.util.Set;
1414
import java.util.TreeSet;
1515

16-
import static io.ebean.querybean.generator.Constants.AT_GENERATED;
17-
import static io.ebean.querybean.generator.Constants.AT_TYPEQUERYBEAN;
18-
import static io.ebean.querybean.generator.Constants.DATABASE;
19-
import static io.ebean.querybean.generator.Constants.DB;
20-
import static io.ebean.querybean.generator.Constants.FETCHGROUP;
21-
import static io.ebean.querybean.generator.Constants.QUERY;
22-
import static io.ebean.querybean.generator.Constants.TQASSOCBEAN;
23-
import static io.ebean.querybean.generator.Constants.TQPROPERTY;
24-
import static io.ebean.querybean.generator.Constants.TQROOTBEAN;
25-
import static io.ebean.querybean.generator.Constants.TRANSACTION;
26-
import static io.ebean.querybean.generator.Constants.TYPEQUERYBEAN;
27-
2816
/**
2917
* A simple implementation that generates and writes query beans.
3018
*/
@@ -104,14 +92,14 @@ private void gatherPropertyDetails() {
10492
importTypes.add(generated);
10593
}
10694
importTypes.add(beanFullName);
107-
importTypes.add(TQROOTBEAN);
108-
importTypes.add(TYPEQUERYBEAN);
109-
importTypes.add(DATABASE);
110-
importTypes.add(FETCHGROUP);
111-
importTypes.add(QUERY);
112-
importTypes.add(TRANSACTION);
95+
importTypes.add(Constants.TQROOTBEAN);
96+
importTypes.add(Constants.TYPEQUERYBEAN);
97+
importTypes.add(Constants.DATABASE);
98+
importTypes.add(Constants.FETCHGROUP);
99+
importTypes.add(Constants.QUERY);
100+
importTypes.add(Constants.TRANSACTION);
113101
if (dbName != null) {
114-
importTypes.add(DB);
102+
importTypes.add(Constants.DB);
115103
}
116104
addClassProperties();
117105
}
@@ -206,14 +194,14 @@ void writeAssocBean() throws IOException {
206194
*/
207195
private void prepareAssocBeanImports() {
208196

209-
importTypes.remove(DB);
210-
importTypes.remove(TQROOTBEAN);
211-
importTypes.remove(DATABASE);
212-
importTypes.remove(FETCHGROUP);
213-
importTypes.remove(QUERY);
214-
importTypes.add(TQASSOCBEAN);
197+
importTypes.remove(Constants.DB);
198+
importTypes.remove(Constants.TQROOTBEAN);
199+
importTypes.remove(Constants.DATABASE);
200+
importTypes.remove(Constants.FETCHGROUP);
201+
importTypes.remove(Constants.QUERY);
202+
importTypes.add(Constants.TQASSOCBEAN);
215203
if (isEntity()) {
216-
importTypes.add(TQPROPERTY);
204+
importTypes.add(Constants.TQPROPERTY);
217205
importTypes.add(origDestPackage + ".Q" + origShortName);
218206
}
219207

@@ -287,9 +275,9 @@ private void writeClass() {
287275
writer.append(" * THIS IS A GENERATED OBJECT, DO NOT MODIFY THIS CLASS.").eol();
288276
writer.append(" */").eol();
289277
if (processingContext.isGeneratedAvailable()) {
290-
writer.append(AT_GENERATED).eol();
278+
writer.append(Constants.AT_GENERATED).eol();
291279
}
292-
writer.append(AT_TYPEQUERYBEAN).eol();
280+
writer.append(Constants.AT_TYPEQUERYBEAN).eol();
293281
lang().beginAssocClass(writer, shortName, origShortName);
294282

295283
} else {
@@ -299,9 +287,9 @@ private void writeClass() {
299287
writer.append(" * THIS IS A GENERATED OBJECT, DO NOT MODIFY THIS CLASS.").eol();
300288
writer.append(" */").eol();
301289
if (processingContext.isGeneratedAvailable()) {
302-
writer.append(AT_GENERATED).eol();
290+
writer.append(Constants.AT_GENERATED).eol();
303291
}
304-
writer.append(AT_TYPEQUERYBEAN).eol();
292+
writer.append(Constants.AT_TYPEQUERYBEAN).eol();
305293
lang().beginClass(writer, shortName);
306294
}
307295

0 commit comments

Comments
 (0)