#33 - Refactor tidy some warnings add final etc

Author: rbygrave

src/main/java/io/ebean/datasource/pool/ConnectionPool.java

@@ -134,12 +134,12 @@ public class ConnectionPool implements DataSourcePool {
   /**
    * Synchronization monitor for the heartBeat timer.
    */
-  private Object heartBeatMonitor = new Object();
+  private final Object heartBeatMonitor = new Object();
 
   /**
    * HeartBeat checking will discover when it goes down, and comes back up again.
    */
-  private AtomicBoolean dataSourceUp = new AtomicBoolean(false);
+  private final AtomicBoolean dataSourceUp = new AtomicBoolean(false);
 
   /**
    * Stores the dataSourceDown-reason (if there is any)
@@ -149,7 +149,7 @@ public class ConnectionPool implements DataSourcePool {
   /**
    * The current alert.
    */
-  private AtomicBoolean inWarningMode = new AtomicBoolean();
+  private final AtomicBoolean inWarningMode = new AtomicBoolean();
 
   /**
    * The minimum number of connections this pool will maintain.

src/main/java/io/ebean/datasource/pool/PooledConnection.java

@@ -333,18 +333,15 @@ void returnPreparedStatement(ExtendedPreparedStatement pstmt) {
    * This will try to use a cache of PreparedStatements.
    */
   public PreparedStatement prepareStatement(String sql, int returnKeysFlag) throws SQLException {
-    String key = new StringBuilder(sql.length() + 50)
-      .append(sql).append(':').append(currentSchema)
-      .append(':').append(returnKeysFlag).toString();
+    String key = sql + ':' + currentSchema + ':' + returnKeysFlag;
     return prepareStatement(sql, true, returnKeysFlag, key);
   }
 
   /**
    * This will try to use a cache of PreparedStatements.
    */
   public PreparedStatement prepareStatement(String sql) throws SQLException {
-    String key = new StringBuilder(sql.length() + 50)
-      .append(sql).append(':').append(currentSchema).toString();
+    String key = sql + ':' + currentSchema;
     return prepareStatement(sql, false, 0, key);
   }