#60 - Remove longRunning flag from PooledConnection

Author: rbygrave

ebean-datasource/src/main/java/io/ebean/datasource/pool/BusyConnectionBuffer.java

@@ -92,7 +92,7 @@ void closeBusyConnections(long leakTimeMinutes) {
         //tmp.add(slots[i]);
         PooledConnection pc = slots[i];
         //noinspection StatementWithEmptyBody
-        if (pc.isLongRunning() || pc.getLastUsedTime() > olderThanTime) {
+        if (pc.getLastUsedTime() > olderThanTime) {
           // PooledConnection has been used recently or
           // expected to be longRunning so not closing...
         } else {

ebean-datasource/src/main/java/io/ebean/datasource/pool/PooledConnection.java

@@ -71,11 +71,6 @@ final class PooledConnection extends ConnectionDelegator {
    * The reason for a connection closing.
    */
   private String closeReason;
-  /**
-   * Set this to true if the connection will be busy for a long time.
-   * This means it should skip the suspected connection pool leak checking.
-   */
-  private boolean longRunning;
   /**
    * Flag to indicate that this connection had errors and should be checked to
    * make sure it is okay.
@@ -175,21 +170,6 @@ String getFullDescription() {
     return "name[" + name + "] startTime[" + getStartUseTime() + "] busySeconds[" + getBusySeconds() + "] stackTrace[" + getStackTraceAsString() + "] stmt[" + getLastStatement() + "]";
   }
 
-  /**
-   * Return true if the connection should be treated as long running (skip connection pool leak check).
-   */
-  boolean isLongRunning() {
-    return longRunning;
-  }
-
-  /**
-   * Set this to true if the connection is a long running connection and should skip the
-   * 'suspected connection pool leak' checking.
-   */
-  public void setLongRunning(boolean longRunning) {
-    this.longRunning = longRunning;
-  }
-
   /**
    * Close the connection fully NOT putting in back into the pool.
    * <p>
@@ -361,7 +341,6 @@ void resetForUse() {
     this.createdByMethod = null;
     this.lastStatement = null;
     this.hadErrors = false;
-    this.longRunning = false;
   }
 
   /**

ebean-datasource/src/main/java/io/ebean/datasource/pool/PreparedStatementDelegator.java

@@ -7,7 +7,7 @@
 import java.sql.*;
 import java.util.Calendar;
 
-class PreparedStatementDelegator implements PreparedStatement {
+abstract class PreparedStatementDelegator implements PreparedStatement {
 
   protected final PreparedStatement delegate;