Use standard getters/setters for DataSourceAlert and DataSourceListener

Author: rbygrave

src/main/java/org/avaje/datasource/Factory.java

@@ -8,7 +8,7 @@
 public class Factory implements DataSourceFactory {
 
   @Override
-  public DataSourcePool createPool(String name, DataSourceConfig config, DataSourceAlert alert, DataSourcePoolListener listener) {
-    return new ConnectionPool(name, config, alert, listener);
+  public DataSourcePool createPool(String name, DataSourceConfig config) {
+    return new ConnectionPool(name, config);
   }
 }

src/main/java/org/avaje/datasource/pool/ConnectionPool.java

@@ -171,14 +171,10 @@ public class ConnectionPool implements DataSourcePool {
   private long leakTimeMinutes;
 
   public ConnectionPool(String name, DataSourceConfig params) {
-    this(name, params, null, null);
-  }
-
-  public ConnectionPool(String name, DataSourceConfig params, DataSourceAlert notify, DataSourcePoolListener listener) {
 
-    this.notify = notify;
     this.name = name;
-    this.poolListener = listener;
+    this.notify = params.getAlert();
+    this.poolListener = params.getListener();
 
     this.autoCommit = params.isAutoCommit();
     this.transactionIsolation = params.getIsolationLevel();

src/test/java/org/avaje/datasource/FactoryTest.java

@@ -18,7 +18,7 @@ public void createPool() throws Exception {
     config.setUsername("sa");
     config.setPassword("");
 
-    DataSourcePool pool = factory.createPool("test", config, null, null);
+    DataSourcePool pool = factory.createPool("test", config);
 
     Connection connection = pool.getConnection();