demo: working example of _stmt suffix handling#44
Open
ebembi-crdb wants to merge 2 commits into
Open
Conversation
This demonstrates the _stmt suffix handling: - Name ends with _stmt - Points to existing grammar rule show_csettings_stmt - Automation will create show_system_info.html (no _stmt)
SQL Diagram Generation Report✅ Validation Passed 🔄 Diagram changes detected Changed Diagram Previewsshow_system_info Showing 1 changed diagram(s). Only diagrams that differ from master are shown. SKIP DOC Warnings (click to expand)The following grammar rules are suppressed from documentation: This comment was generated by the SQL Diagram CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Working Demo of _stmt Suffix Handling
This PR demonstrates the automation correctly handling the _stmt suffix edge case.
What this adds:
show_system_info_stmtshow_csettings_stmtExpected automation behavior:
Bazel files will be auto-updated:
show_system_info_stmt.bnf(with suffix)show_system_info.html(WITHOUT suffix)Diagram will be generated successfully
A PR will be created in generated-diagrams repo
This proves:
The automation correctly strips _stmt from HTML files while keeping it for BNF files, preventing the naming conflicts mentioned in the meeting notes.