Renamed to "Concerning..."

Author: ebkr

…nents/banner/VulnerablePackageBanner.vue …nents/banner/ConcerningPackageBanner.vuesrc/components/banner/VulnerablePackageBanner.vue renamed to src/components/banner/ConcerningPackageBanner.vue src/components/banner/VulnerablePackageBanner.vue renamed to src/components/banner/ConcerningPackageBanner.vue

@@ -2,16 +2,18 @@
 
 import { getStore } from '@r2/providers/generic/store/StoreProvider';
 import { State } from '@r2/store';
+import { useConcerningPackageComposable } from '@r2/components/composables/ConcerningPackageComposable';
 
 const store = getStore<State>();
+const { hasConcerningPackages } = useConcerningPackageComposable();
 
 function addUnlinkedFilter() {
     store.commit('profile/scopeLocalModListToUnlinkedPackages');
 }
 </script>
 
 <template>
-    <div class="notification is-concern margin-right">
+    <div class="notification is-concern margin-right" v-show="hasConcerningPackages">
         <span>You have packages that can no longer be found on Thunderstore.</span> <a href="#" @click.stop.prevent="addUnlinkedFilter">Click here to review packages.</a>
     </div>
 </template>

…mposables/VulnerablePackageComposable.ts …mposables/ConcerningPackageComposable.tssrc/components/composables/VulnerablePackageComposable.ts renamed to src/components/composables/ConcerningPackageComposable.ts src/components/composables/VulnerablePackageComposable.ts renamed to src/components/composables/ConcerningPackageComposable.ts

@@ -15,21 +15,21 @@ const onlineModList = computed<Map<string, ThunderstoreMod>>(() => {
     return new Map<string, ThunderstoreMod>(mods.map(value => [value.getFullName(), value]));
 });
 
-const vulnerablePackages = computed<ManifestV2[]>(() => {
+const concerningPackages = computed<ManifestV2[]>(() => {
     return localModList.value.filter(value => !value.isTrustedPackage() && (value.isOnlineSource() && !onlineModList.value.has(value.getName())));
 });
 
-export function useVulnerablePackageComposable() {
+export function useConcerningPackageComposable() {
 
-    const hasVulnerablePackages = computed<boolean>(() => vulnerablePackages.value.length > 0);
+    const hasConcerningPackages = computed<boolean>(() => concerningPackages.value.length > 0);
 
-    function isVulnerablePackage(mod: ManifestV2) {
-        return vulnerablePackages.value.findIndex(value => value.getName() === mod.getName()) >= 0;
+    function isConcerningPackage(mod: ManifestV2) {
+        return concerningPackages.value.findIndex(value => value.getName() === mod.getName()) >= 0;
     }
 
     return {
-        vulnerablePackages,
-        hasVulnerablePackages,
-        isVulnerablePackage
+        concerningPackages,
+        hasConcerningPackages,
+        isConcerningPackage
     }
 }

…/modals/VulnerablePackageReviewModal.vue …/modals/ConcerningPackageReviewModal.vuesrc/components/modals/VulnerablePackageReviewModal.vue renamed to src/components/modals/ConcerningPackageReviewModal.vue src/components/modals/VulnerablePackageReviewModal.vue renamed to src/components/modals/ConcerningPackageReviewModal.vue

@@ -4,20 +4,20 @@ import ModalCard from '@r2/components/ModalCard.vue';
 import { State } from '@r2/store';
 import { getStore } from '@r2/providers/generic/store/StoreProvider';
 import ManifestV2 from '@r2/model/ManifestV2';
-import { useModManagementComposable } from 'components/composables/ModManagementComposable';
+import { useModManagementComposable } from '@r2/components/composables/ModManagementComposable';
 import R2Error from '@r2/model/errors/R2Error';
 import ProfileModList from '@r2/r2mm/mods/ProfileModList';
 
 const store = getStore<State>();
 
 const { uninstallMod } = useModManagementComposable();
 
-const isOpen = computed(() => store.state.modals.isVulnerableModReviewModalOpen);
-const modToReview = computed<ManifestV2 | null>(() => store.state.modals.vulnerableModToReview);
+const isOpen = computed(() => store.state.modals.isConcerningModReviewModalOpen);
+const modToReview = computed<ManifestV2 | null>(() => store.state.modals.concerningModToReview);
 const profile = computed(() => store.getters['profile/activeProfile']);
 
 function close() {
-    store.commit('closeVulnerableModReviewModal');
+    store.commit('closeConcerningModReviewModal');
 }
 
 async function removeMod() {

src/components/views/LocalModList.vue

@@ -9,7 +9,7 @@
         <AssociatedModsModal />
 
         <ManagerUpdateBanner/>
-        <VulnerablePackageBanner v-if="hasVulnerablePackages"/>
+        <ConcerningPackageBanner/>
 
         <slot name="above-list"></slot>
 
@@ -50,13 +50,10 @@ import { State } from '../../store';
 import { computed, defineAsyncComponent } from 'vue';
 import SkeletonLocalModCard from './LocalModList/SkeletonLocalModCard.vue';
 import ManagerUpdateBanner from '../banner/ManagerUpdateBanner.vue';
-import VulnerablePackageBanner from '@r2/components/banner/VulnerablePackageBanner.vue';
-import { useVulnerablePackageComposable } from '@r2/components/composables/VulnerablePackageComposable';
+import ConcerningPackageBanner from '@r2/components/banner/ConcerningPackageBanner.vue';
 
 const store = getStore<State>();
 
-const { hasVulnerablePackages } = useVulnerablePackageComposable();
-
 const LocalModDraggableList = defineAsyncComponent(() => import('./LocalModList/LocalModDraggableList.vue'));
 
 const visibleModList = computed(() => store.getters['profile/visibleModList']);

src/components/views/LocalModList/LocalModCard.vue

@@ -12,7 +12,7 @@ import { splitToNameAndVersion } from '../../../utils/DependencyUtils';
 import { computed, onMounted, ref, watch } from 'vue';
 import { getStore } from '../../../providers/generic/store/StoreProvider';
 import { State } from '../../../store';
-import { useVulnerablePackageComposable } from '@r2/components/composables/VulnerablePackageComposable';
+import { useConcerningPackageComposable } from '@r2/components/composables/ConcerningPackageComposable';
 import { useModManagementComposable } from '@r2/components/composables/ModManagementComposable';
 
 const store = getStore<State>();
@@ -23,7 +23,7 @@ type LocalModCardProps = {
 
 const props = defineProps<LocalModCardProps>();
 
-const { isVulnerablePackage } = useVulnerablePackageComposable();
+const { isConcerningPackage } = useConcerningPackageComposable();
 const { uninstallMod } = useModManagementComposable();
 
 const disabledDependencies = ref<ManifestV2[]>([]);
@@ -165,7 +165,7 @@ function dependencyStringToModName(x: string) {
 }
 
 function openReviewModal() {
-    store.commit('openVulnerableModReviewModal', props.mod);
+    store.commit('openConcerningModReviewModal', props.mod);
 }
 </script>
 
@@ -176,7 +176,7 @@ function openReviewModal() {
         :id="`${mod.getAuthorName()}-${mod.getName()}-${mod.getVersionNumber()}`"
         :image="mod.getIcon()"
         :allowSorting="true"
-        :class="[{'card--is-concern': isVulnerablePackage(props.mod)}]"
+        :class="[{'card--is-concern': isConcerningPackage(props.mod)}]"
     >
 
         <template v-slot:title>
@@ -207,19 +207,19 @@ function openReviewModal() {
 
         <template v-slot:description>
             <p class='card-timestamp' v-if="mod.getInstalledAtTime() !== 0"><strong>Installed on:</strong> {{ getReadableDate(mod.getInstalledAtTime()) }}</p>
-            <div class="notification is-warning" v-if="isVulnerablePackage(props.mod)">
+            <div class="notification is-warning" v-if="isConcerningPackage(props.mod)">
                 <p>This package was originally downloaded from Thunderstore however can no longer be found.</p>
                 <p>Mods can be removed due to the author's request or due to violating Thunderstore's package policies.</p>
                 <p><strong>It is recommended to remove this mod.</strong></p>
-                <button v-if="isVulnerablePackage(props.mod)" class="button" @click.stop.prevent="openReviewModal">
+                <button v-if="isConcerningPackage(props.mod)" class="button" @click.stop.prevent="openReviewModal">
                     Review package
                 </button>
             </div>
         </template>
 
         <!-- Show icon button row even when card is collapsed -->
         <template v-slot:other-icons>
-            <span v-if="isVulnerablePackage(props.mod)"
+            <span v-if="isConcerningPackage(props.mod)"
                   class='card-header-icon'>
                 <i v-tooltip.left="`This package can no longer be found on Thunderstore`"
                    class='fas fa-unlink'

src/components/views/LocalModList/LocalModDraggableList.vue

@@ -22,11 +22,11 @@ import { State } from '../../../store';
 import ManifestV2 from '../../../model/ManifestV2';
 import R2Error from '../../../model/errors/R2Error';
 import { ImmutableProfile } from '../../../model/Profile';
-import { useVulnerablePackageComposable } from '@r2/components/composables/VulnerablePackageComposable';
+import { useConcerningPackageComposable } from '@r2/components/composables/ConcerningPackageComposable';
 
 const store = getStore<State>();
 
-const { isVulnerablePackage } = useVulnerablePackageComposable();
+const { isConcerningPackage } = useConcerningPackageComposable();
 
 const profile = computed<ImmutableProfile>(() => store.getters['profile/activeProfile'].asImmutableProfile());
 
@@ -38,7 +38,7 @@ function applyVisibleList() {
     const newModList = visibleModList.value;
     const modList = store.state.profile.modList;
     if (store.state.profile.filters.has('Unlinked')) {
-        internalVisibleList.value = modList.filter(value => isVulnerablePackage(value));
+        internalVisibleList.value = modList.filter(value => isConcerningPackage(value));
     } else {
         internalVisibleList.value = newModList;
     }

src/pages/Manager.vue

@@ -118,7 +118,7 @@
         <DownloadProgressModal />
         <DownloadModVersionSelectModal />
         <UpdateAllInstalledModsModal />
-        <VulnerablePackageReviewModal/>
+        <ConcerningPackageReviewModal/>
         <LaunchTypeModal v-if="canRenderLaunchTypeModal()" />
 
         <div class="router-view">
@@ -157,7 +157,7 @@ import path from '../providers/node/path/path';
 import LaunchTypeModal from "../components/modals/launch-type/LaunchTypeModal.vue";
 import appWindow from '../providers/node/app/app_window';
 import GameInstructionParser from "../r2mm/launching/instructions/GameInstructionParser";
-import VulnerablePackageReviewModal from 'components/modals/VulnerablePackageReviewModal.vue';
+import ConcerningPackageReviewModal from 'components/modals/ConcerningPackageReviewModal.vue';
 
 const store = getStore<State>();
 const router = useRouter();

src/store/modules/ModalsModule.ts

@@ -22,8 +22,8 @@ interface State {
     isProfileManagementModalOpen: boolean;
     isProfileCodeExportModalOpen: boolean;
     isLocalFileImportModalOpen: boolean;
-    vulnerableModToReview: ManifestV2 | null;
-    isVulnerableModReviewModalOpen: boolean;
+    concerningModToReview: ManifestV2 | null;
+    isConcerningModReviewModalOpen: boolean;
 }
 
 export default {
@@ -48,8 +48,8 @@ export default {
         isProfileManagementModalOpen: false,
         isProfileCodeExportModalOpen: false,
         isLocalFileImportModalOpen: false,
-        vulnerableModToReview: null,
-        isVulnerableModReviewModalOpen: false,
+        concerningModToReview: null,
+        isConcerningModReviewModalOpen: false,
     }),
 
     mutations: {
@@ -121,8 +121,8 @@ export default {
             state.isLocalFileImportModalOpen = false;
         },
 
-        closeVulnerableModReviewModal: function(state: State): void {
-            state.isVulnerableModReviewModalOpen = false;
+        closeConcerningModReviewModal: function(state: State): void {
+            state.isConcerningModReviewModalOpen = false;
         },
 
         openAssociatedModsModal: function(state: State, mod: ManifestV2): void {
@@ -193,9 +193,9 @@ export default {
             state.isLocalFileImportModalOpen = true;
         },
 
-        openVulnerableModReviewModal: function(state: State, mod: ManifestV2): void {
-            state.vulnerableModToReview = mod;
-            state.isVulnerableModReviewModalOpen = true;
+        openConcerningModReviewModal: function(state: State, mod: ManifestV2): void {
+            state.concerningModToReview = mod;
+            state.isConcerningModReviewModalOpen = true;
         },
     }
 }