WIP: Tag auto-clears when all packages have been resolved

Author: ebkr

src/components/banner/ManagerUpdateBanner.vue

@@ -42,3 +42,9 @@ onMounted(async () => {
         </p>
     </div>
 </template>
+
+<style scoped lang="scss">
+.notification {
+    margin-bottom: 0.5rem;
+}
+</style>

src/components/banner/VulnerablePackageBanner.vue

@@ -21,4 +21,8 @@ function addUnlinkedFilter() {
     background-color: var(--notification-concern-background-color);
     color: var(--notification-concern-text-color);
 }
+
+.notification {
+    margin-bottom: 0.5rem;
+}
 </style>

src/components/composables/VulnerablePackageComposable.ts

@@ -16,8 +16,7 @@ const onlineModList = computed<Map<string, ThunderstoreMod>>(() => {
 });
 
 const vulnerablePackages = computed<ManifestV2[]>(() => {
-    // TODO - Fix logic (post dev testing)
-    return localModList.value.filter(value => !value.isOnlineSource() && !value.isTrustedPackage() && onlineModList.value.has(value.getName()));
+    return localModList.value.filter(value => !value.isTrustedPackage() && (value.isOnlineSource() && !onlineModList.value.has(value.getName())));
 });
 
 export function useVulnerablePackageComposable() {

src/components/modals/VulnerablePackageReviewModal.vue

@@ -27,19 +27,27 @@ async function removeMod() {
 
 async function trustPackage() {
     const mods = await ProfileModList.getModList(profile.value.asImmutableProfile());
+    if (mods instanceof R2Error) {
+        console.error(mods);
+        store.commit('error/handleError', mods);
+        return;
+    }
     const mod = mods.find(value => value.getName() === modToReview.value?.getName());
     if (mod) {
         mod.setTrustedPackage(true);
     }
     try {
-        await store.dispatch(
-            'profile/saveModListToDisk',
-            {mods: mods, profile: profile.value}
-        );
+        const err = await ProfileModList.saveModList(profile.value.asImmutableProfile(), mods);
+        if (err instanceof R2Error) {
+            store.commit('error/handleError', err);
+            return;
+        }
+        await store.dispatch('profile/updateModList', mods);
     } catch (e) {
         store.commit('error/handleError', R2Error.fromThrownValue(e));
+    } finally {
+        close();
     }
-    await close();
 }
 </script>
 

src/components/views/LocalModList.vue

@@ -4,6 +4,15 @@
             <SearchAndSort />
         </div>
 
+        <DisableModModal />
+        <UninstallModModal />
+        <AssociatedModsModal />
+
+        <ManagerUpdateBanner/>
+        <VulnerablePackageBanner v-if="hasVulnerablePackages"/>
+
+        <slot name="above-list"></slot>
+
         <div class="tags has-addons" v-if="filters.size > 0">
             <span class="margin-right" v-for="filter in filters">
                 <a href="#" @click="removeFilter(filter)">
@@ -15,15 +24,6 @@
             </span>
         </div>
 
-        <DisableModModal />
-        <UninstallModModal />
-        <AssociatedModsModal />
-
-        <ManagerUpdateBanner/>
-        <VulnerablePackageBanner v-if="hasVulnerablePackages"/>
-
-        <slot name="above-list"></slot>
-
         <div class="mod-list-content">
             <div class="draggable-content">
                 <Suspense>

src/components/views/LocalModList/LocalModDraggableList.vue

@@ -47,6 +47,12 @@ function applyVisibleList() {
 watch([visibleModList, store.state.profile.filters], applyVisibleList);
 onMounted(applyVisibleList);
 
+watch(internalVisibleList, (newList) => {
+    if (newList.length === 0) {
+        store.commit('profile/removeFilter', 'Unlinked');
+    }
+})
+
 const draggableList = computed({
     get() {
         return internalVisibleList.value;

src/store/index.ts

@@ -138,7 +138,7 @@ export const store = {
 
     // enable strict mode (adds overhead!)
     // for dev mode only
-    strict: import.meta.env.MODE === 'development',
+    strict: import.meta.env.MODE === 'development1',
 };
 
 /*