Conversation
- Keeping installation rules separately in memory is redundant as the InstallRulePluginInstaller reads them for EcosystemSchema now - The code in InstallationRules class are used by the same installer class, so placing them in the same file makes sense - Ingnored the comment about a new implementation for InstallationRules.validate as type safety will give an error if each PackageLoader doesn't define mod loader and plugin installers in the registry file
Accessing the instance of ProfileInstallerProvider actually initiates a new object on each call. While a small overhead, it's still unnecessary as all mods being installed at one go can be assumed to use the same PackageInstaller class.
Use Thunderstore's ecosystem schema as the source of truth.
Some of the usages checked that the package mapping is related to correct PackageLoader, but after the changes the each PackageInstaller should get called only with such packages anyhow, so it feels safe to drop this check.
Checking that the package is a mod loader should suffice, as the uninstall method should be called only if the package is associated with the PackageLoader of the active game.
Ideally the data would be included in the Thunderstore API. Until that day comes, keep the hardocoded values in the EcosystemSchema.
The responsibilities have been taken over by the EcosystemSchema and the file is now unused.
EcosystemSchema now provides the data using the format used by the schema. This differs a bit from the old interface, but current usage only accesses rootFolder attribute so it doesn't matter.
- Add explicit return types to avoid accidental future changes - Simplify "best fit rule" by dropping checks for impossible undefined
ebkr
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.