Refactor: Streamline GitHub Actions workflow

This commit refactors the Android GitHub Actions workflow for improved efficiency and clarity.

Key changes include:

-   **Removed Container for Setup Job:** The `setup` job no longer runs in a Docker container, simplifying the environment.
-   **Simplified Ruby & Bundler Setup:**
    -   Updated Ruby version from 3.2 to 3.1.
    -   Leveraged `bundler-cache: true` in `ruby/setup-ruby` action for faster dependency installation.
    -   Removed explicit `bundle-path` output and its usage in subsequent steps.
    -   Simplified Bundler installation commands.
-   **Direct Secret Usage:** Keystore and key passwords are now directly accessed from secrets within the `local.properties` creation step, removing the need for environment variables for these secrets.
-   **Removed Redundant PATH Environment Variable:** The explicit setting of `PATH` environment variable in deployment and build jobs has been removed as Bundler now handles the execution path.
-   **Improved Step Naming:** Renamed some steps for better clarity (e.g., "Build with Fastlane" instead of "Run buildBundle lane").

Author: eby-dev

.github/workflows/android.yml

@@ -10,19 +10,12 @@ on:
 
 env:
   KEYSTORE_FILE: keystore-qrbarcode.jks
-  KEYSTORE_PASSWORD: ${{ secrets.KEYSTORE_PASSWORD }}
-  KEY_ALIAS: ${{ secrets.KEY_ALIAS }}
-  KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
   GOOGLE_PLAY_JSON_PATH: app/qrbarcode-8b0b8-aaefa03b2374.json
 
 jobs:
   setup:
     name: Setup Environment
     runs-on: ubuntu-latest
-    container:
-      image: softartdev/android-fastlane:33
-    outputs:
-      bundle-path: ${{ steps.set-bundle-path.outputs.bundle-path }}
 
     steps:
       - name: Checkout Repository
@@ -40,25 +33,19 @@ jobs:
       - name: Setup Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.2'
-
-      - name: Set Bundle Path Output
-        id: set-bundle-path
-        run: echo "bundle-path=${HOME}/.gem/ruby/3.2.0/bin" >> $GITHUB_OUTPUT
+          ruby-version: '3.1'
+          bundler-cache: true
 
       - name: Cache Ruby Gems
         uses: actions/cache@v4
         with:
           path: vendor/bundle
           key: ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }}
 
-      - name: Install Bundler & Fastlane
+      - name: Install Fastlane via Bundler
         run: |
-          gem install bundler:2.5.11 --user-install
-          bundle _2.5.11_ config set path vendor/bundle
-          bundle _2.5.11_ install
-        env:
-          PATH: "${{ steps.set-bundle-path.outputs.bundle-path }}:${PATH}"
+          bundle config set path 'vendor/bundle'
+          bundle install
 
       - name: Decode Keystore File
         run: echo "${{ secrets.KEYSTORE_FILE }}" | base64 -d > $KEYSTORE_FILE
@@ -67,9 +54,9 @@ jobs:
         run: |
           echo "sdk.dir=$ANDROID_HOME" > local.properties
           echo "KEYSTORE_FILE=$KEYSTORE_FILE" >> local.properties
-          echo "KEYSTORE_PASSWORD=$KEYSTORE_PASSWORD" >> local.properties
-          echo "KEY_ALIAS=$KEY_ALIAS" >> local.properties
-          echo "KEY_PASSWORD=$KEY_PASSWORD" >> local.properties
+          echo "KEYSTORE_PASSWORD=${{ secrets.KEYSTORE_PASSWORD }}" >> local.properties
+          echo "KEY_ALIAS=${{ secrets.KEY_ALIAS }}" >> local.properties
+          echo "KEY_PASSWORD=${{ secrets.KEY_PASSWORD }}" >> local.properties
 
       - name: Create Google Service Account JSON
         run: |
@@ -83,11 +70,8 @@ jobs:
 
     steps:
       - uses: actions/checkout@v3
-
-      - name: Run buildBundle lane
+      - name: Build with Fastlane
         run: bundle exec fastlane buildBundle
-        env:
-          PATH: "${{ needs.setup.outputs.bundle-path }}:${PATH}"
 
       - name: Upload Bundle Artifact
         uses: actions/upload-artifact@v4
@@ -104,8 +88,6 @@ jobs:
       - uses: actions/checkout@v3
       - name: Run Tests
         run: bundle exec fastlane test
-        env:
-          PATH: "${{ needs.setup.outputs.bundle-path }}:${PATH}"
 
   code-analysis:
     name: Lint & Check
@@ -132,10 +114,8 @@ jobs:
 
     steps:
       - uses: actions/checkout@v3
-      - name: Deploy
+      - name: Deploy Release
         run: bundle exec fastlane deployRelease
-        env:
-          PATH: "${{ needs.setup.outputs.bundle-path }}:${PATH}"
 
   deploy-beta:
     name: Deploy to Play Store (Beta)
@@ -145,10 +125,8 @@ jobs:
 
     steps:
       - uses: actions/checkout@v3
-      - name: Deploy
+      - name: Deploy Beta
         run: bundle exec fastlane deployBeta
-        env:
-          PATH: "${{ needs.setup.outputs.bundle-path }}:${PATH}"
 
   deploy-firebase-internal:
     name: Distribute via Firebase (Internal)
@@ -158,7 +136,5 @@ jobs:
 
     steps:
       - uses: actions/checkout@v3
-      - name: Deploy
+      - name: Deploy Firebase Internal
         run: bundle exec fastlane deployFirebase --verbose
-        env:
-          PATH: "${{ needs.setup.outputs.bundle-path }}:${PATH}"