Skip to content

Clarity fixes#1

Open
roelofjan-elsinga wants to merge 5 commits into
ec2-software:masterfrom
roelofjan-elsinga:master
Open

Clarity fixes#1
roelofjan-elsinga wants to merge 5 commits into
ec2-software:masterfrom
roelofjan-elsinga:master

Conversation

@roelofjan-elsinga

@roelofjan-elsinga roelofjan-elsinga commented Jun 8, 2022 •
edited
Loading

Copy link
Copy Markdown
  • Renamed "Plugin" to "Extension", because they're two different things in GQLgen
  • Fixed the interface, the Extension shouldn't have methods with a pointer receiver according to the interface definition
  • Rename the struct fields for Extension/Plugin -> The intention is now clearer. Does FilterField == true return the field or remove it? It's now ReturnField, which is easier to read.
  • Updated the example code to give extra context
  • Added type definition as third parameter to the FieldFilter, because you might want to return a field based on the parent type

Roelof Jan Elsinga added 5 commits June 8, 2022 13:43
- Renamed filters to be more explicit
45ae33b 
- Fixed interface implementation of the extension (no pointers)
- Renamed Plugin to Extension, because they're 2 different things
- Added type definition as third input to the field filter
Updated example for clarity
79bcda4
spaces vs tabs
520fcf6
spaces vs tabs
39216d8
rename to extension
bcccb39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@roelofjan-elsinga