docs: Clarify attestation_with_dal applies to all key types#673
Open
michaelkernaghan wants to merge 1 commit into
Open
docs: Clarify attestation_with_dal applies to all key types#673michaelkernaghan wants to merge 1 commit into
michaelkernaghan wants to merge 1 commit into
Conversation
Fixes #671 - Clarify that attestation_with_dal policy is required for ALL key types when DAL node is connected - Add detailed explanation of tz1/tz2/tz3 behavior with DAL node - Distinguish between attestation encoding vs shard attestation capability - Add concrete log examples from Seoulnet testing - Update baker command examples for both tz1 and tz4 scenarios - Add new 'DAL Behavior by Key Type' section with practical examples The documentation now accurately reflects that the attestation_with_dal encoding is triggered by DAL node connectivity, not key type. Testing on Seoulnet demonstrated that tz1 keys do sign attestation_with_dal operations when a DAL node is connected, even without shard attestation capability (bitset 0). This prevents operators from mistakenly omitting the attestation_with_dal policy for tz1-only setups.
jevonearth
force-pushed
the
671-dal-doc-clarify-tz1-behavior
branch
from
19fe86b to
fbe03e0
Compare
Deploying signatory with
|
| Latest commit: |
fbe03e0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b84df472.signatory.pages.dev |
| Branch Preview URL: | https://671-dal-doc-clarify-tz1-beha.signatory.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #671
The documentation now accurately reflects that the attestation_with_dal encoding is triggered by DAL node connectivity, not key type. Testing on Seoulnet demonstrated that tz1 keys do sign attestation_with_dal operations when a DAL node is connected, even without shard attestation capability (bitset 0). This prevents operators from mistakenly omitting the attestation_with_dal policy for tz1-only setups.
Note
Cursor Bugbot is generating a summary for commit fbe03e0. Configure here.