feat(security): add local pwned-password list#10197
Draft
BacLuc wants to merge 1 commit into
Draft
Conversation
Use NotPwnedPasswordValidator that checks against a local copy of the top 3000 HaveIBeenPwned passwords (SHA1, sorted). This satisfies OWASP ASVS 6.2.4 without requiring external HTTP calls in production or test environments. https://github.com/OWASP/ASVS/blob/master/5.0/en/0x15-V6-Authentication.md#v6-authentication Do not use remote password list, as this api request may fail. Symfony's NativePasswordHasher pre-hashes passwords >72 bytes with SHA-512 before bcrypt, so the 72-byte truncation limitation does not apply. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: BacLuc <lucius.bachmann@clubpage.ch>
Contributor
Author
|
The password list is not good yet. (contains passwords with less than 12 characters). We need to decide: do we want to do this and make our users angry for the not so critical ecamp? (Maybe we should disclose that we do not treat ecamp3 as critical an no one should store medical data or other critical things in ecamp?). |
Member
Core Meeting DecisionWe do this and don't do #10198 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use NotPwnedPasswordValidator that checks against a local copy of the top 3000 HaveIBeenPwned passwords (SHA1, sorted). This satisfies OWASP ASVS 6.2.4 without requiring external HTTP calls in production or test environments. https://github.com/OWASP/ASVS/blob/master/5.0/en/0x15-V6-Authentication.md#v6-authentication Do not use remote password list, as this api request may fail.
Symfony's NativePasswordHasher
pre-hashes passwords >72 bytes with SHA-512 before bcrypt, so the 72-byte truncation limitation does not apply.