Use precalculated hasChecklists flag for checklist navigation item#9698
Open
manuelmeister wants to merge 8 commits into
Open
Use precalculated hasChecklists flag for checklist navigation item#9698manuelmeister wants to merge 8 commits into
manuelmeister wants to merge 8 commits into
Conversation
carlobeltrame
left a comment
carlobeltrame
left a comment
Member
There was a problem hiding this comment.
Not only courses may use checklists, and not only checklists determine whether a camp is a course or not. Can we name this a little more neutrally, e.g. hasChecklists?
manuelmeister
changed the title
manuelmeister
changed the title
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
✅ Feature branch deployment ready!
|
BacLuc
reviewed
May 7, 2026
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
Member
Author
Core Meeting DecisionWe don't want a DB field. This could be solved with replacing the collection link with a array of iris (removing the ApiFilter on Checklist.php for camp) |
…rmance/prevent-checklist-request # Conflicts: # api/src/Entity/Camp.php
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
BacLuc
requested changes
Jul 12, 2026
BacLuc
left a comment
BacLuc
left a comment
Contributor
There was a problem hiding this comment.
I don't think this is a good idea.
Try to load https://pr9698.ecamp3.ch/camps/5d28f99890bc/PBS-CH-361-25/dashboard
compare this to
https://dev.ecamp3.ch/camps/5d28f99890bc/PBS-CH-361-25/dashboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this we can save us an initial call to checklists.