Skip to content

Commit 061cd30

Browse files
authored
Merge branch 'develop' into bugfix/improveReadonlyCodeEditorAppearance-CMEM-7723
2 parents 763b9af + 611cef7 commit 061cd30

3 files changed

Lines changed: 13 additions & 0 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
2525
- border of the BlueprintJS `Tag` elements were fixed
2626
- `<CodeEditor />`
2727
- `readOnly` appearance uses same borders like read-only text fields and it does not display a blinking cursor
28+
- `<Button />`, `<IconButton />`
29+
- outlines for focus by keyboard navigation are better recognizable on buttons with colored backgrounds (intent states)
2830

2931
### Changed
3032

src/components/Button/button.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,11 @@ $button-intents: (
116116
@include pt-button-intent(map.get($button-intents, $intentvalue)...);
117117
}
118118

119+
&:focus-visible {
120+
box-shadow: inset 0 0 0 $eccgui-size-inline-whitespace * 0.6
121+
#{eccgui-color-var("identity", "background", "100")} !important;
122+
}
123+
119124
&.#{$ns}-minimal,
120125
&.#{$ns}-outlined {
121126
color: list.nth(map.get($button-intents, $intentvalue), 1);

src/components/Icon/icon.scss

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,12 @@ svg.#{$eccgui}-icon {
5555
& > .#{$eccgui}-tooltip__wrapper + .#{$ns}-button-text {
5656
margin-left: 0;
5757
}
58+
59+
&[class*="#{$ns}-intent-"] {
60+
.#{$eccgui}-tooltip__wrapper [tabindex="0"] {
61+
outline-color: currentcolor;
62+
}
63+
}
5864
}
5965

6066
.#{$eccgui}-menu__item {

0 commit comments

Comments
 (0)