Skip to content

Commit 763b9af

Browse files
committed
improve read-only appearance
1 parent 6ac22fa commit 763b9af

2 files changed

Lines changed: 14 additions & 0 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
2323

2424
- `<MultiSelect />`
2525
- border of the BlueprintJS `Tag` elements were fixed
26+
- `<CodeEditor />`
27+
- `readOnly` appearance uses same borders like read-only text fields and it does not display a blinking cursor
2628

2729
### Changed
2830

src/extensions/codemirror/_codemirror.scss

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,18 @@ $eccgui-size-codeeditor-toolbar-height: $button-height !default;
6464
padding: 0;
6565
}
6666

67+
&:has(.cm-content[aria-readonly="true"]) {
68+
box-shadow: inset 0 0 0 1px $pt-divider-black;
69+
70+
&:focus {
71+
box-shadow: input-transition-shadow($input-shadow-color-focus, true), $input-box-shadow-focus;
72+
}
73+
74+
.cm-cursor {
75+
display: none;
76+
}
77+
}
78+
6779
&[class*="#{$eccgui}-intent--"] {
6880
animation-duration: 1s;
6981
animation-delay: 0.5s;

0 commit comments

Comments
 (0)