Skip to content

Commit a2a6deb

Browse files
Merge branch 'develop' into feature/reusableRuleBlocks-CMEM-1590
# Conflicts: # CHANGELOG.md
2 parents faf3b0c + 0614a72 commit a2a6deb

4 files changed

Lines changed: 27 additions & 0 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
2525

2626
- `<MultiSelect />`
2727
- border of the BlueprintJS `Tag` elements were fixed
28+
- `<CodeEditor />`
29+
- `readOnly` appearance uses same borders like read-only text fields and it does not display a blinking cursor
30+
- `<Button />`, `<IconButton />`
31+
- outlines for focus by keyboard navigation are better recognizable on buttons with colored backgrounds (intent states)
2832
- `extendedTooltip` of a handle in the ReactFlow (v12) component does not show the tooltip.
2933

3034
### Changed

src/components/Button/button.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,11 @@ $button-intents: (
116116
@include pt-button-intent(map.get($button-intents, $intentvalue)...);
117117
}
118118

119+
&:focus-visible {
120+
box-shadow: inset 0 0 0 $eccgui-size-inline-whitespace * 0.6
121+
#{eccgui-color-var("identity", "background", "100")} !important;
122+
}
123+
119124
&.#{$ns}-minimal,
120125
&.#{$ns}-outlined {
121126
color: list.nth(map.get($button-intents, $intentvalue), 1);

src/components/Icon/icon.scss

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,12 @@ svg.#{$eccgui}-icon {
5555
& > .#{$eccgui}-tooltip__wrapper + .#{$ns}-button-text {
5656
margin-left: 0;
5757
}
58+
59+
&[class*="#{$ns}-intent-"] {
60+
.#{$eccgui}-tooltip__wrapper [tabindex="0"] {
61+
outline-color: currentcolor;
62+
}
63+
}
5864
}
5965

6066
.#{$eccgui}-menu__item {

src/extensions/codemirror/_codemirror.scss

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,18 @@ $eccgui-size-codeeditor-toolbar-height: $button-height !default;
6464
padding: 0;
6565
}
6666

67+
&:has(.cm-content[aria-readonly="true"]) {
68+
box-shadow: inset 0 0 0 1px $pt-divider-black;
69+
70+
&:focus {
71+
box-shadow: input-transition-shadow($input-shadow-color-focus, true), $input-box-shadow-focus;
72+
}
73+
74+
.cm-cursor {
75+
display: none;
76+
}
77+
}
78+
6779
&[class*="#{$eccgui}-intent--"] {
6880
animation-duration: 1s;
6981
animation-delay: 0.5s;

0 commit comments

Comments
 (0)