Skip to content

Do not calculate relative offset for highlighting ranges received from parse errors #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haschek merged 6 commits into from
Oct 15, 2025
Merged

Do not calculate relative offset for highlighting ranges received from parse errors #337

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eab7825
Do not calculate relative offset for highlighting ranges received fro…
andreas-schultz Oct 10, 2025
70ade27
Merge branch 'next' into feature/keyValueParameterType-CMEM-6277
andreas-schultz Oct 10, 2025
1824ca1
Add changelog entry
andreas-schultz Oct 14, 2025
f977e3c
Merge branch 'next' into feature/keyValueParameterType-CMEM-6277
haschek Oct 14, 2025
f955b60
Merge branch 'next' into feature/keyValueParameterType-CMEM-6277
haschek Oct 14, 2025
faae1b7
Merge branch 'next' into feature/keyValueParameterType-CMEM-6277
haschek Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/components/AutoSuggestion/AutoSuggestion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,12 +317,11 @@ const AutoSuggestion = ({
};
if (parseError) {
const { message, start, end } = parseError;
const { toOffset, fromOffset } = getOffsetRange(cm, start, end);
clearCurrentErrorMarker();
const { from, to } = markText({
view: cm,
from: fromOffset,
to: toOffset,
from: start,
to: end,
className: `${eccgui}-autosuggestion__text--highlighted-error`,
title: message,
});
Expand Down