Skip to content

Add docker build and push github action#296

Merged
eric-eclecticiq merged 11 commits into
masterfrom
add-docker-push
Dec 9, 2025
Merged

Add docker build and push github action#296
eric-eclecticiq merged 11 commits into
masterfrom
add-docker-push

Conversation

@eric-eclecticiq

@eric-eclecticiq eric-eclecticiq commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

Motivation

Provide up-to-date images in the docker repository: https://hub.docker.com/r/eclecticiq/opentaxii

Changes

  1. Add a job to do the docker actions in publish.yml
  2. Pypi publish job is (still) only run on tag push
  3. Docker job is not login and pushing in PR mode, only the build is tested.
  4. Docker job pushes new images for master merge and pushed tags. A custom meta is provided as we use semver without the prefix v
  5. The compose files accept a custom tag as an env var

Docker metadata documentation: https://github.com/docker/metadata-action

Note: I initially tested that a login/push worked with this MR in the following job.

@eric-eclecticiq eric-eclecticiq requested a review from saaj December 9, 2025 11:08

@saaj saaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CD (regarding artefacts) policy looks good.

Docker job is not login and pushing in PR mode, only the build is tested.

Note: I initially tested that a login/push worked with this MR in the following job.

But the job output looks like it did push. I assume it was with some rules temporarily omitted, and you removing the test image manually.

@eric-eclecticiq eric-eclecticiq merged commit a3b142c into master Dec 9, 2025
9 checks passed
@eric-eclecticiq eric-eclecticiq deleted the add-docker-push branch December 9, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants