Resolve default package managers in config worker#4776
Merged
sschuberth merged 2 commits intomainfrom Apr 29, 2026
Merged
Conversation
mnonnenmacher
force-pushed
the
default-package-managers
branch
2 times, most recently
from
c947e1e to
eda7cc6
Compare
mnonnenmacher
requested review from
MarcelBochtler,
bs-ondem,
nnobelis,
oheger-bosch,
sschuberth and
wkl3nk
as code owners
sschuberth
requested changes
Apr 28, 2026
| * template is assigned to the organization, or `null` if no template exists for the organization. | ||
| */ | ||
| internal fun getTemplateForOrganization( | ||
| fun getTemplateForOrganization( |
Contributor
There was a problem hiding this comment.
Commit message nit: "plugin templated" -> "plugin template"
mnonnenmacher
force-pushed
the
default-package-managers
branch
from
eda7cc6 to
ccbf83a
Compare
Move the `getDefaultPackageManagers` logic from the analyzer worker to the config worker so that the default package managers are resolved before the validation script runs. This makes the resolution transparent to the script, which can now see and potentially override the defaults. The resolved defaults are stored in `resolvedJobConfigs`, keeping all job config resolution in one place. The analyzer worker no longer needs to inject default package managers at runtime. This is also a preparation for applying plugin templates in the config worker which requires that the actually used package managers are already known. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@doubleopen.org>
If a plugin is set to `RESTRICTED`, it is only available in organizations where a plugin template is configured for the plugin. Respect that when determining the default list of enabled package managers in the config worker. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@doubleopen.io>
mnonnenmacher
force-pushed
the
default-package-managers
branch
from
ccbf83a to
d98e0a1
Compare
sschuberth
approved these changes
Apr 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the
getDefaultPackageManagerslogic from the analyzer worker tothe config worker so that the default package managers are resolved
before the validation script runs. This makes the resolution transparent
to the script, which can now see and potentially override the defaults.
The resolved defaults are stored in
resolvedJobConfigs, keeping alljob config resolution in one place. The analyzer worker no longer needs
to inject default package managers at runtime.
This is also a preparation for applying plugin templates in the config
worker which requires that the actually used package managers are
already known.