fix(ui): Prefer fixed plugin option values over values from last run#5270
Open
mnonnenmacher wants to merge 1 commit into
Open
fix(ui): Prefer fixed plugin option values over values from last run#5270mnonnenmacher wants to merge 1 commit into
mnonnenmacher wants to merge 1 commit into
Conversation
d281577 to
31e776c
Compare
Contributor
"options" -> "option"
Maybe explicitly add "... and do not reject the run". |
If a plugin options is set to a fixed value in a plugin template, that value is enforced by the backend: If a different value for that option is sent to the API, the run request is rejected. This could cause issues when starting a run with "rerun" and plugin templates were changed in the meantime, because a plugin option used for the last run may now not be allowed anymore. To fix this, always prefer fixed plugin option values over values used by the last run. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@doubleopen.io>
31e776c to
40e7a42
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



If a plugin options is set to a fixed value in a plugin template, that value is enforced by the backend: If a different value for that option is sent to the API, the run request is rejected.
This could cause issues when starting a run with "rerun" and plugin templates were changed in the meantime, because a plugin option used for the last run may now not be allowed anymore.
To fix this, always prefer fixed plugin option values over values used by the last run.