ui: Add support to package configuration providers to ORT run create form#5333
Conversation
Etsija
requested review from
lamppu,
mnonnenmacher and
sschuberth
as code owners
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Etsija
force-pushed
the
pkg-config-providers
branch
from
cb1ce77 to
d93f50c
Compare
Pull request was converted to draft
Etsija
force-pushed
the
pkg-config-providers
branch
from
d93f50c to
76d262e
Compare
Etsija
force-pushed
the
pkg-config-providers
branch
from
76d262e to
8437cb9
Compare
Add package configuration provider fields to the create-run form schema, default values, rerun restoration, validation, and payload conversion. Selected providers are submitted via `jobConfigs.evaluator.packageConfigurationProviders`, or via `jobConfigs.reporter.packageConfigurationProviders` when the evaluator job is disabled. Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.io>
Show package configuration provider fields in the create-run evaluator and reporter settings. Hide the reporter field when the evaluator is enabled because the backend uses the evaluator providers in that case. As for analyzer / package curation providers, order of the package configuration providers matters, so use the same drag-and-drop logic here. Note that as the package configuration providers are added, the `isSuperuser` guard is only applied to the "Keep worker alive" part of the evaluator configuration. Resolves #5238. Signed-off-by: Jyrki Keisala <jyrki.keisala@doubleopen.io>
Etsija
force-pushed
the
pkg-config-providers
branch
from
8437cb9 to
3b1eb87
Compare
This could also be confusing to users in some situations. For example, if they configure the package configuration providers in the reporter job and then enable the evaluator job, will the configuration they made before just disappear? An alternative could be to keep the section in both jobs and automatically sync the content. However, we have to start somewhere, so to me it would be fine to keep the current approach and then iterate on that later if necessary. |
I'm fine with keeping the current approach and collect user experience, then change later if it proves useful. |
3 participants
As requested, the reporter section is only rendered, when evaluator job is disabled. As with package curation providers, order of the package configuration providers matter, so drag-and-drop is supported and its behavior is similar to #5295.