added filter for sm repo#209
Merged
Merged
Conversation
FriedJannik
requested changes
Jun 2, 2026
FriedJannik
left a comment
FriedJannik
left a comment
Member
There was a problem hiding this comment.
Thank you for this nice addition :)
aaronzi
reviewed
Jun 2, 2026
| if b.Index.stringValue != nil { | ||
| if b.Alias == "submodel_element.idshort_path" && strings.HasSuffix(*b.Index.stringValue, "[]") { | ||
| prefix := strings.TrimSuffix(*b.Index.stringValue, "[]") | ||
| where = append(where, goqu.I(b.Alias).Like(goqu.L("? || '[%'", prefix))) |
Member
There was a problem hiding this comment.
is this [%to broad because it only queries in the list or is this intentional?
Contributor
Author
There was a problem hiding this comment.
this is a extrem edge case. here an example:
if you use $sme.a[]#value you want the values of the items of a and not the value of a.
aaronzi
added
the
docker-snapshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #208