Skip to content

Extracts parts of code from submodel_database.go#349

Merged
aaronzi merged 4 commits into
eclipse-basyx:mainfrom
FriedJannik:refactor/submodelDatabase
Jun 9, 2026
Merged

Extracts parts of code from submodel_database.go#349
aaronzi merged 4 commits into
eclipse-basyx:mainfrom
FriedJannik:refactor/submodelDatabase

Conversation

@FriedJannik

@FriedJannik FriedJannik commented Jun 9, 2026

Copy link
Copy Markdown
Member

This PR refactors submodel_database.go

  • Split into smaller files with less responsibilities
  • Extract Queries into own file

@FriedJannik FriedJannik marked this pull request as ready for review June 9, 2026 07:44
@aaronzi aaronzi requested a review from Copilot June 9, 2026 08:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Submodel Repository PostgreSQL persistence layer by extracting previously monolithic logic from submodel_database.go into smaller, responsibility-focused files and by moving SQL construction into a dedicated queries package.

Changes:

  • Split persistence logic into dedicated read/write/history/visibility/signing database files.
  • Extracted SQL builders from persistence into internal/submodelrepository/persistence/queries/submodel_database_queries.go.
  • Updated signing APIs and tests to use separate GetSignedSubmodel and GetSignedSubmodelValueOnly methods instead of a valueOnly boolean parameter.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
internal/submodelrepository/persistence/submodel_write_database.go New file containing submodel create/patch/put/delete write logic and related helpers.
internal/submodelrepository/persistence/submodel_visibility.go New file extracting ABAC visibility checks and formula enforcement helper.
internal/submodelrepository/persistence/submodel_signing.go New file extracting JWS signing logic into separate full vs value-only methods.
internal/submodelrepository/persistence/submodel_read_database.go New file containing submodel read/query/list logic and cursor helpers.
internal/submodelrepository/persistence/submodel_history_database.go New file extracting submodel history append/snapshot helpers.
internal/submodelrepository/persistence/submodel_file_attachment_database.go New file extracting File attachment CRUD + history-wrapped operations.
internal/submodelrepository/persistence/submodel_element_write_database.go New file containing submodel element write operations and value-only update logic.
internal/submodelrepository/persistence/submodel_database.go Reduced to core SubmodelDatabase struct and constructors after extraction.
internal/submodelrepository/persistence/submodel_database_signed_test.go Updated tests to match new signing method split.
internal/submodelrepository/persistence/submodel_database_query_utils.go Deleted legacy SQL builder utilities after moving builders to queries package.
internal/submodelrepository/persistence/queries/submodel_database_queries.go New centralized SQL builder module for submodel persistence.
internal/submodelrepository/api/api_submodel_repository_api_service.go Updated signing endpoints to call the new signing methods.
Files not reviewed (1)
  • internal/submodelrepository/api/api_submodel_repository_api_service.go: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/submodelrepository/persistence/submodel_element_write_database.go Outdated
Comment thread internal/submodelrepository/persistence/submodel_read_database.go
FriedJannik and others added 2 commits June 9, 2026 10:58
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@aaronzi aaronzi merged commit 09f1536 into eclipse-basyx:main Jun 9, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants