Skip to content

Commit 077e91f

Browse files
Build(deps): Bump openapitools.version from 6.6.0 to 7.23.0 (#981)
* Build(deps): Bump openapitools.version from 6.6.0 to 7.23.0 Bumps `openapitools.version` from 6.6.0 to 7.23.0. Updates `org.openapitools:openapi-generator` from 6.6.0 to 7.23.0 - [Release notes](https://github.com/openapitools/openapi-generator/releases) - [Changelog](https://github.com/OpenAPITools/openapi-generator/blob/master/docs/release-summary.md) - [Commits](OpenAPITools/openapi-generator@v6.6.0...v7.23.0) Updates `org.openapitools:openapi-generator-maven-plugin` from 6.6.0 to 7.23.0 --- updated-dependencies: - dependency-name: org.openapitools:openapi-generator dependency-version: 7.20.0 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: org.openapitools:openapi-generator-maven-plugin dependency-version: 7.20.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Fixes necessary for the new version * Fixes remaining testfailures --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aaron Zielstorff <aaron.zielstorff@iese.fraunhofer.de>
1 parent 4988a13 commit 077e91f

21 files changed

Lines changed: 115 additions & 66 deletions

File tree

basyx.aasregistry/basyx.aasregistry-client-native/pom.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,11 @@
8787
<generateSupportingFiles>true</generateSupportingFiles>
8888
<templateDirectory>${project.basedir}/templates</templateDirectory>
8989
<supportingFilesToGenerate>
90-
AbstractOpenApiSchema.java,ServerConfiguration.java,ServerVariable.java,Configuration.java,JSON.java,ApiException.java,ApiResponse.java,ApiClient.java,Pair.java,RFC3339DateFormat.java
90+
AbstractOpenApiSchema.java,ServerConfiguration.java,ServerVariable.java,Configuration.java,JSON.java,ApiException.java,ApiResponse.java,ApiClient.java,Pair.java,RFC3339DateFormat.java,RFC3339InstantDeserializer.java,RFC3339JavaTimeModule.java
9191
</supportingFilesToGenerate>
9292
<configOptions>
93+
<enumPropertyNaming>legacy</enumPropertyNaming>
94+
<containerDefaultToNull>true</containerDefaultToNull>
9395
<java8>true</java8>
9496
<dateLibrary>java8</dateLibrary>
9597
<sourceFolder>java</sourceFolder>

basyx.aasregistry/basyx.aasregistry-client-native/src/test/java/org/eclipse/digitaltwin/basyx/aasregistry/main/client/mapper/AttributeMapperFixture.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public class AttributeMapperFixture {
103103

104104
// Extension AasRegistry
105105
private static final org.eclipse.digitaltwin.basyx.aasregistry.client.model.Extension AAS_REG_EXTENSION = new org.eclipse.digitaltwin.basyx.aasregistry.client.model.Extension().semanticId(AAS_REG_DATASPECIFICATION).name("extension")
106-
.valueType(DataTypeDefXsd.STRING).value("extensionValue");
106+
.valueType(DataTypeDefXsd.XS_STRING).value("extensionValue");
107107

108108
// ExternalSubjectId AAS4J
109109
private static final Reference AAS4J_EXTERNAL_SUBJECT_ID = new DefaultReference.Builder().keys(new DefaultKey.Builder().type(KeyTypes.BLOB).value("BlobValue").build()).type(ReferenceTypes.EXTERNAL_REFERENCE).build();

basyx.aasregistry/basyx.aasregistry-feature-hierarchy/src/test/java/org/eclipse/digitaltwin/basyx/aasregistry/feature/hierarchy/LocalhostHierarchicalAasRegistryTest.java

Lines changed: 26 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import org.junit.AfterClass;
3030
import org.junit.BeforeClass;
3131
import org.springframework.boot.SpringApplication;
32+
import org.springframework.boot.web.server.context.WebServerApplicationContext;
3233
import org.springframework.context.ConfigurableApplicationContext;
3334

3435
/**
@@ -39,26 +40,39 @@
3940
*/
4041
public class LocalhostHierarchicalAasRegistryTest extends HierarchicalAasRegistryTestSuite {
4142

42-
private static final String ROOT_REGISTRY_URL = "http://localhost:8081";
43-
private static final String DELEGATED_REGISTRY_URL = "http://localhost:8050";
44-
4543
private static final String REPO_BASE_URL = "http://localhost:8080";
46-
private static final String DELEGATED_AASID = "http://localhost:8050/test/aas";
4744

48-
private static final RegistryAndDiscoveryInterfaceApi rootRegistryApi = new RegistryAndDiscoveryInterfaceApi(ROOT_REGISTRY_URL);
49-
private static final RegistryAndDiscoveryInterfaceApi delegatedRegistryApi = new RegistryAndDiscoveryInterfaceApi(DELEGATED_REGISTRY_URL);
50-
private static final DummyDescriptorFactory factory = new DummyDescriptorFactory(REPO_BASE_URL, DELEGATED_AASID);
45+
private static RegistryAndDiscoveryInterfaceApi rootRegistryApi;
46+
private static RegistryAndDiscoveryInterfaceApi delegatedRegistryApi;
47+
private static DummyDescriptorFactory factory;
5148

52-
private static ConfigurableApplicationContext appContext;
49+
private static ConfigurableApplicationContext rootAppContext;
50+
private static ConfigurableApplicationContext delegatedAppContext;
5351

5452
@BeforeClass
55-
public static void setupRootRegistry() {
56-
appContext = new SpringApplication(DummyAasRegistryComponent.class).run(new String[] {});
53+
public static void setupRegistries() {
54+
delegatedAppContext = new SpringApplication(DummyAasRegistryComponent.class).run(new String[] { "--server.port=0", "--basyx.feature.hierarchy.enabled=false" });
55+
rootAppContext = new SpringApplication(DummyAasRegistryComponent.class).run(new String[] { "--server.port=0" });
56+
57+
String rootRegistryUrl = localUrl(rootAppContext);
58+
String delegatedRegistryUrl = localUrl(delegatedAppContext);
59+
60+
rootRegistryApi = new RegistryAndDiscoveryInterfaceApi(rootRegistryUrl);
61+
delegatedRegistryApi = new RegistryAndDiscoveryInterfaceApi(delegatedRegistryUrl);
62+
factory = new DummyDescriptorFactory(REPO_BASE_URL, delegatedRegistryUrl + "/test/aas");
5763
}
5864

5965
@AfterClass
60-
public static void tearDownRootRegistry() {
61-
appContext.close();
66+
public static void tearDownRegistries() {
67+
if (rootAppContext != null)
68+
rootAppContext.close();
69+
70+
if (delegatedAppContext != null)
71+
delegatedAppContext.close();
72+
}
73+
74+
private static String localUrl(ConfigurableApplicationContext applicationContext) {
75+
return "http://localhost:" + ((WebServerApplicationContext) applicationContext).getWebServer().getPort();
6276
}
6377

6478
@Override

basyx.aasregistry/basyx.aasregistry-service-basemodel/pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,8 @@
7979
<output>${project.basedir}/${generated.folder}</output>
8080

8181
<configOptions>
82+
<enumPropertyNaming>legacy</enumPropertyNaming>
83+
<containerDefaultToNull>true</containerDefaultToNull>
8284
<java8>true</java8>
8385
<dateLibrary>java8</dateLibrary>
8486
<sourceFolder>java</sourceFolder>

basyx.aasregistry/basyx.aasregistry-service-basetests/src/main/java/org/eclipse/digitaltwin/basyx/aasregistry/service/tests/AasRegistryStorageTest.java

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public void whenRegisterSubmodelDescriptorNullModel_thenNullPointer() {
6363
@Test
6464
public void whenRegisterSubmodelDescriptorUnknownId_thenThrowNotFound() {
6565
List<AssetAdministrationShellDescriptor> initialState = getAllAasDescriptors();
66-
SubmodelDescriptor ignored = new SubmodelDescriptor("ignored", List.of());
66+
SubmodelDescriptor ignored = submodelDescriptor("ignored");
6767
assertThrows(AasDescriptorNotFoundException.class, () -> storage.insertSubmodel(UNKNOWN, ignored));
6868
List<AssetAdministrationShellDescriptor> currentState = getAllAasDescriptors();
6969
assertThat(currentState).isEqualTo(initialState);
@@ -75,7 +75,7 @@ public void whenRegisterSubmodelDescriptorAndWasAlreadyPresent_thenElementIsOver
7575
List<AssetAdministrationShellDescriptor> initialState = getAllAasDescriptors();
7676
List<AssetAdministrationShellDescriptor> expected = testResourcesLoader.loadList(AssetAdministrationShellDescriptor.class);
7777
assertThat(initialState).isNotEqualTo(expected);
78-
SubmodelDescriptor toAdd = new SubmodelDescriptor(IDENTIFICATION_2_2, List.of()).addDescriptionItem(new LangStringTextType("de-DE", "Overridden"));
78+
SubmodelDescriptor toAdd = submodelDescriptor(IDENTIFICATION_2_2).addDescriptionItem(new LangStringTextType("de-DE", "Overridden"));
7979
storage.replaceSubmodel(IDENTIFICATION_2, toAdd.getId(), toAdd);
8080
List<AssetAdministrationShellDescriptor> newState = getAllAasDescriptors();
8181
assertThat(newState).asList().isNotEqualTo(initialState).containsExactlyInAnyOrderElementsOf(expected);
@@ -87,7 +87,7 @@ public void whenRegisterSubmodelDescriptorAndWasNotAlreadyPresent_thenElementIsA
8787
List<AssetAdministrationShellDescriptor> initialState = getAllAasDescriptors();
8888
List<AssetAdministrationShellDescriptor> expected = testResourcesLoader.loadList(AssetAdministrationShellDescriptor.class);
8989
assertThat(initialState).isNotEqualTo(expected);
90-
SubmodelDescriptor toAdd = new SubmodelDescriptor(IDENTIFICATION_2_3, List.of());
90+
SubmodelDescriptor toAdd = submodelDescriptor(IDENTIFICATION_2_3);
9191

9292
// RegistryTestObjects.addDefaultEndpoint(toAdd);
9393
storage.insertSubmodel(IDENTIFICATION_2, toAdd);
@@ -295,7 +295,7 @@ public void whenRegisterAssetAdministrationShellDescriptor_thenStored() throws I
295295
List<AssetAdministrationShellDescriptor> expected = testResourcesLoader.loadList(AssetAdministrationShellDescriptor.class);
296296
assertThat(initialState).isNotEqualTo(expected);
297297
AssetAdministrationShellDescriptor testResource = new AssetAdministrationShellDescriptor(IDENTIFICATION_NEW);
298-
SubmodelDescriptor subModel = new SubmodelDescriptor(IDENTIFICATION_NEW_1, List.of());
298+
SubmodelDescriptor subModel = submodelDescriptor(IDENTIFICATION_NEW_1);
299299
testResource.setSubmodelDescriptors(Collections.singletonList(subModel));
300300
storage.insertAasDescriptor(testResource);
301301
List<AssetAdministrationShellDescriptor> newState = getAllAasDescriptors();
@@ -402,25 +402,25 @@ public void whenTryToReplaceUnknownDescriptor_thenThrowException() {
402402

403403
@Test
404404
public void whenInsertSubmodelAndAlreadyExists_thenThrowException() {
405-
SubmodelDescriptor descr = new SubmodelDescriptor(IDENTIFICATION_2_1, List.of());
405+
SubmodelDescriptor descr = submodelDescriptor(IDENTIFICATION_2_1);
406406
assertThrows(SubmodelAlreadyExistsException.class, () -> storage.insertSubmodel(IDENTIFICATION_2, descr));
407407
}
408408

409409
@Test
410410
public void whenInsertSubmodelAndAasDescriptorNotFound_thenThrowException() {
411-
SubmodelDescriptor descr = new SubmodelDescriptor(IDENTIFICATION_2_1, List.of());
411+
SubmodelDescriptor descr = submodelDescriptor(IDENTIFICATION_2_1);
412412
assertThrows(AasDescriptorNotFoundException.class, () -> storage.insertSubmodel(UNKNOWN, descr));
413413
}
414414

415415
@Test
416416
public void whenReplaceSubmodelAndNotAvailable_thenThrowException() {
417-
SubmodelDescriptor descr = new SubmodelDescriptor(UNKNOWN, List.of());
417+
SubmodelDescriptor descr = submodelDescriptor(UNKNOWN);
418418
assertThrows(SubmodelNotFoundException.class, () -> storage.replaceSubmodel(IDENTIFICATION_1, UNKNOWN, descr));
419419
}
420420

421421
@Test
422422
public void whenReplaceSubmodelAndDescriptorNotAvailable_thenThrowException() {
423-
SubmodelDescriptor descr = new SubmodelDescriptor(UNKNOWN, List.of());
423+
SubmodelDescriptor descr = submodelDescriptor(UNKNOWN);
424424
assertThrows(DescriptorNotFoundException.class, () -> storage.replaceSubmodel(UNKNOWN, UNKNOWN, descr));
425425
}
426426

@@ -431,16 +431,20 @@ public void whenInsertAasDescriptorAndDescriptorAlreadyAvailable_thenThrowExcept
431431

432432
@Test
433433
public void whenReplaceSubmodelAndWithDifferentId_thenEventIsSent() throws IOException {
434-
SubmodelDescriptor descr = new SubmodelDescriptor(IDENTIFICATION_NEW, List.of());
434+
SubmodelDescriptor descr = submodelDescriptor(IDENTIFICATION_NEW);
435435
storage.replaceSubmodel(IDENTIFICATION_2, IDENTIFICATION_2_1, descr);
436436
verifyEventsSent();
437437
}
438438

439439
@Test
440440
public void whenReplaceSubmodelButNotFound_thenThrowNotFound() {
441-
SubmodelDescriptor sm = new SubmodelDescriptor(IDENTIFICATION_NEW, List.of());
441+
SubmodelDescriptor sm = submodelDescriptor(IDENTIFICATION_NEW);
442442
assertThrows(SubmodelNotFoundException.class, () -> storage.replaceSubmodel(IDENTIFICATION_1, IDENTIFICATION_NEW, sm));
443443
verifyNoEventSent();
444444
}
445445

446-
}
446+
private static SubmodelDescriptor submodelDescriptor(String id) {
447+
return new SubmodelDescriptor().id(id);
448+
}
449+
450+
}

basyx.aasregistry/basyx.aasregistry-service-basetests/src/main/java/org/eclipse/digitaltwin/basyx/aasregistry/service/tests/integration/BaseIntegrationTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@
4848
import org.eclipse.digitaltwin.basyx.aasregistry.client.model.AdministrativeInformation;
4949
import org.eclipse.digitaltwin.basyx.aasregistry.client.model.AssetAdministrationShellDescriptor;
5050
import org.eclipse.digitaltwin.basyx.aasregistry.client.model.AssetKind;
51-
import org.eclipse.digitaltwin.basyx.aasregistry.client.model.DataSpecificationContent;
5251
import org.eclipse.digitaltwin.basyx.aasregistry.client.model.DataSpecificationIec61360;
5352
import org.eclipse.digitaltwin.basyx.aasregistry.client.model.DataTypeIec61360;
5453
import org.eclipse.digitaltwin.basyx.aasregistry.client.model.EmbeddedDataSpecification;
@@ -564,7 +563,7 @@ public void whenSendFullObjectStructure_ItemIsProcessedProperly() throws ApiExce
564563
dsContent.addDefinitionItem(new LangStringDefinitionTypeIec61360().language(LANG_DE_DE).text("def")).addPreferredNameItem(new LangStringPreferredNameTypeIec61360().language(LANG_DE_DE).text("prefName"))
565564
.addShortNameItem(new LangStringShortNameTypeIec61360().language(LANG_DE_DE).text("sn")).dataType(DataTypeIec61360.FILE).levelType(new LevelType().max(true).min(false).nom(false).typ(true)).sourceOfDefinition("sod")
566565
.symbol("$$");
567-
EmbeddedDataSpecification edSpec = new EmbeddedDataSpecification().dataSpecification(reference).dataSpecificationContent(new DataSpecificationContent(dsContent));
566+
EmbeddedDataSpecification edSpec = new EmbeddedDataSpecification().dataSpecification(reference).dataSpecificationContent(dsContent);
568567

569568
AdministrativeInformation aInfo = new AdministrativeInformation().addEmbeddedDataSpecificationsItem(edSpec);
570569
SubmodelDescriptor sm = new SubmodelDescriptor().id("sm").id("short").addDescriptionItem(dType).addDisplayNameItem(nType).addEndpointsItem(ep).addExtensionsItem(ext).addSupplementalSemanticIdsItem(reference);
@@ -680,4 +679,4 @@ private <O,I> O convert(I in, Class<I> inCls, Class<O> outCls) throws JsonProces
680679
return mapper.readerFor(outCls).readValue(data);
681680
}
682681

683-
}
682+
}

basyx.aasregistry/basyx.aasregistry-service-inmemory-storage/src/test/java/org/eclipse/digitaltwin/basyx/aasregistry/service/tests/InMemoryAasRegistyStorageTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,12 @@ public AasRegistryStorage createCloningInMemoryStorage() {
5454
@Test
5555
public void whenInsertDescriptorWithDuplicateSubmodelIds_thenThrowException() throws IOException {
5656
AssetAdministrationShellDescriptor descr = new AssetAdministrationShellDescriptor(IDENTIFICATION_NEW);
57-
descr.addSubmodelDescriptorsItem(new SubmodelDescriptor(IDENTIFICATION_NEW_1, List.of()));
58-
descr.addSubmodelDescriptorsItem(new SubmodelDescriptor(IDENTIFICATION_NEW_1, List.of()));
57+
descr.addSubmodelDescriptorsItem(new SubmodelDescriptor().id(IDENTIFICATION_NEW_1));
58+
descr.addSubmodelDescriptorsItem(new SubmodelDescriptor().id(IDENTIFICATION_NEW_1));
5959

6060
assertThrows(DuplicateSubmodelIds.class, ()->storage.insertAasDescriptor(descr));
6161

6262
verifyNoEventSent();
6363
}
6464

65-
}
65+
}

basyx.aasregistry/basyx.aasregistry-service-mongodb-storage/pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,8 @@
100100

101101
<!-- See https://openapi-generator.tech/docs/generators/spring -->
102102
<configOptions>
103+
<enumPropertyNaming>legacy</enumPropertyNaming>
104+
<containerDefaultToNull>true</containerDefaultToNull>
103105
<openApiNullable>false</openApiNullable>
104106
<java8>true</java8>
105107
<dateLibrary>java8</dateLibrary>

basyx.aasregistry/basyx.aasregistry-service-mongodb-storage/src/test/java/org/eclipse/digitaltwin/basyx/aasregistry/service/tests/ProjectionTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public void testSegmentBlockCollectorEndpointProtocolVersion() {
6565

6666
@Test
6767
public void testSegmentBlockCollectorDataSpecificationContentDefinition() {
68-
String path = AasRegistryPaths.submodelDescriptors().administration().embeddedDataSpecifications().dataSpecificationContent().asDataSpecificationIec61360().definition().text();
68+
String path = AasRegistryPaths.submodelDescriptors().administration().embeddedDataSpecifications().dataSpecificationContent().definition().text();
6969
assertSegmentBlocksCreated(path, false, "submodelDescriptors", "administration.embeddedDataSpecifications", "dataSpecificationContent.definition", "text");
7070
}
7171

basyx.aasregistry/basyx.aasregistry-service/pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,8 @@
9898
<templateDirectory>${project.basedir}/templates</templateDirectory>
9999
<!-- See https://openapi-generator.tech/docs/generators/spring -->
100100
<configOptions>
101+
<enumPropertyNaming>legacy</enumPropertyNaming>
102+
<containerDefaultToNull>true</containerDefaultToNull>
101103
<java8>true</java8>
102104
<dateLibrary>java8</dateLibrary>
103105
<sourceFolder>java</sourceFolder>

0 commit comments

Comments
 (0)