Change deleteSubmodelReferenceByIdAasRepository to return NO_CONTENT (#961)

* Change deleteSubmodelReferenceByIdAasRepository to return NO_CONTENT status

* Fix delete response assertion to expect NO_CONTENT status

* Fix delete response assertion to expect NO_CONTENT status

Author: dk-emag

basyx.aasrepository/basyx.aasrepository-feature-authorization/src/test/java/org/eclipse/digitaltwin/basyx/aasrepository/feature/authorization/TestAuthorizedAasRepository.java

@@ -427,7 +427,7 @@ public void removeSubmodelReferenceWithCorrectRoleAndPermission() throws IOExcep
 		String accessToken = getAccessToken(DummyCredentialStore.BASYX_ASSET_UPDATER_CREDENTIAL);
 
 		CloseableHttpResponse retrievalResponse = deleteElementWithAuthorization(getSpecificSubmodelReferenceUrl(SPECIFIC_SHELL_ID_2, "http://i40.customer.com/type/1/1/testSubmodel"), accessToken);
-		assertEquals(HttpStatus.OK.value(), retrievalResponse.getCode());
+		assertEquals(HttpStatus.NO_CONTENT.value(), retrievalResponse.getCode());
 
 		deleteElementWithAuthorization(getSpecificAasAccessURL(SPECIFIC_SHELL_ID_2), getAccessToken(DummyCredentialStore.ADMIN_CREDENTIAL));
 	}
@@ -439,7 +439,7 @@ public void removeSubmodelReferenceWithCorrectRoleAndSpecificAasPermission() thr
 		String accessToken = getAccessToken(DummyCredentialStore.BASYX_ASSET_UPDATER_TWO_CREDENTIAL);
 
 		CloseableHttpResponse retrievalResponse = deleteElementWithAuthorization(getSpecificSubmodelReferenceUrl(SPECIFIC_SHELL_ID_2, "http://i40.customer.com/type/1/1/testSubmodel"), accessToken);
-		assertEquals(HttpStatus.OK.value(), retrievalResponse.getCode());
+		assertEquals(HttpStatus.NO_CONTENT.value(), retrievalResponse.getCode());
 
 		deleteElementWithAuthorization(getSpecificAasAccessURL(SPECIFIC_SHELL_ID_2), getAccessToken(DummyCredentialStore.ADMIN_CREDENTIAL));
 	}

basyx.aasrepository/basyx.aasrepository-http/src/main/java/org/eclipse/digitaltwin/basyx/aasrepository/http/AasRepositoryApiHTTPController.java

@@ -105,7 +105,7 @@ public ResponseEntity<Void> putAssetAdministrationShellById(
 	@Override
 	public ResponseEntity<Void> deleteSubmodelReferenceByIdAasRepository(Base64UrlEncodedIdentifier aasIdentifier, Base64UrlEncodedIdentifier submodelIdentifier) {
 		aasRepository.removeSubmodelReference(aasIdentifier.getIdentifier(), submodelIdentifier.getIdentifier());
-		return new ResponseEntity<Void>(HttpStatus.OK);
+		return new ResponseEntity<Void>(HttpStatus.NO_CONTENT);
 	}
 
 	@Override

basyx.aasrepository/basyx.aasrepository-http/src/test/java/org/eclipse/digitaltwin/basyx/aasrepository/http/AasRepositoryHTTPSuite.java

@@ -280,7 +280,7 @@ public void removeSubmodelReference() throws FileNotFoundException, IOException,
 		CloseableHttpResponse deleteResponse = BaSyxHttpTestUtils.executeDeleteOnURL(url);
 		CloseableHttpResponse getResponse = BaSyxHttpTestUtils.executeGetOnURL(getSpecificAasSubmodelRefAccessURL(dummyAasId));
 
-		assertEquals(200, deleteResponse.getCode());
+		assertEquals(204, deleteResponse.getCode());
 
 		String response = BaSyxHttpTestUtils.getResponseAsString(getResponse);
 		BaSyxHttpTestUtils.assertSameJSONContent(getSMReferenceRemovalJson(), getJSONWithoutCursorInfo(response));