Skip to content

Commit 58ab66c

Browse files
author
faheem
committed
exclusion optimization and discovery behaviour adjust acc to actual
1 parent c883574 commit 58ab66c

2 files changed

Lines changed: 5 additions & 20 deletions

File tree

  • basyx.aasdigitaltwinregistry/basyx.digitaltwinregistry.component/src/main/java/org/eclipse/digitaltwin/basyx/digitaltwinregistry/component
  • basyx.aasregistry/basyx.aasregistry-feature-discovery-integration/src/main/java/org/eclipse/digitaltwin/basyx/aasregistry/feature/discovery/integration

basyx.aasdigitaltwinregistry/basyx.digitaltwinregistry.component/src/main/java/org/eclipse/digitaltwin/basyx/digitaltwinregistry/component/DigitalTwinRegistry.java

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,9 @@
2525

2626
package org.eclipse.digitaltwin.basyx.digitaltwinregistry.component;
2727

28-
2928
import org.eclipse.digitaltwin.basyx.aasdiscoveryservice.component.AasDiscoveryServiceComponent;
30-
import org.eclipse.digitaltwin.basyx.aasdiscoveryservice.component.AasDiscoveryServiceFeaturePrinter;
31-
3229
import org.eclipse.digitaltwin.basyx.aasregistry.service.api.*;
3330
import org.eclipse.digitaltwin.basyx.aasregistry.service.configuration.HomeController;
34-
import org.eclipse.digitaltwin.basyx.aasregistry.service.configuration.MongoDbConfiguration;
3531
import org.eclipse.digitaltwin.basyx.aasregistry.service.events.RegistryEventLogSink;
3632
import org.springframework.boot.SpringApplication;
3733
import org.springframework.boot.autoconfigure.SpringBootApplication;
@@ -98,17 +94,10 @@
9894
type = FilterType.ASSIGNABLE_TYPE,
9995
value = org.eclipse.digitaltwin.basyx.aasregistry.service.configuration.SpringDocConfiguration.class
10096
),
101-
@ComponentScan.Filter(
102-
type = FilterType.ASSIGNABLE_TYPE,
103-
value = AasDiscoveryServiceFeaturePrinter.class
104-
),
97+
10598
@ComponentScan.Filter(
10699
type = FilterType.ASSIGNABLE_TYPE,
107100
value = org.eclipse.digitaltwin.basyx.aasdiscoveryservice.http.documentation.AasDiscoveryServiceApiDocumentationConfiguration.class
108-
),
109-
@ComponentScan.Filter(
110-
type = FilterType.ASSIGNABLE_TYPE,
111-
value = MongoDbConfiguration.class
112101
)
113102
}
114103
)

basyx.aasregistry/basyx.aasregistry-feature-discovery-integration/src/main/java/org/eclipse/digitaltwin/basyx/aasregistry/feature/discovery/integration/DiscoveryIntegrationAasRegistry.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ public AssetAdministrationShellDescriptor getAasDescriptor(@NonNull String aasDe
7272
@Override
7373
public void insertAasDescriptor(AssetAdministrationShellDescriptor descr) throws AasDescriptorAlreadyExistsException {
7474
decorated.insertAasDescriptor(descr);
75-
String encodedId = Base64.getEncoder().encodeToString(descr.getId().getBytes());
7675
@Valid List<org.eclipse.digitaltwin.basyx.aasregistry.model.@Valid SpecificAssetId> ids = descr.getSpecificAssetIds();
7776
List<SpecificAssetId> specificAssetIds = ids.stream()
7877
.map(rId -> {
@@ -81,15 +80,12 @@ public void insertAasDescriptor(AssetAdministrationShellDescriptor descr) throws
8180
assetId.setValue(rId.getValue());
8281
return assetId;
8382
}).collect(Collectors.toList());
84-
85-
discoveryApi.createAllAssetLinksById(encodedId, specificAssetIds);
83+
discoveryApi.createAllAssetLinksById(descr.getId(), specificAssetIds);
8684
}
8785

8886
@Override
8987
public void replaceAasDescriptor(@NonNull String aasDescriptorId, @NonNull AssetAdministrationShellDescriptor descriptor) throws AasDescriptorNotFoundException {
9088
decorated.replaceAasDescriptor(aasDescriptorId, descriptor);
91-
String encodedId = Base64.getEncoder().encodeToString(aasDescriptorId.getBytes());
92-
9389
List<SpecificAssetId> specificAssetIds = descriptor.getSpecificAssetIds().stream()
9490
.map(rId -> {
9591
SpecificAssetId assetId = new DefaultSpecificAssetId();
@@ -98,14 +94,14 @@ public void replaceAasDescriptor(@NonNull String aasDescriptorId, @NonNull Asset
9894
return assetId;
9995
}).collect(Collectors.toList());
10096

101-
discoveryApi.deleteAllAssetLinksById(encodedId);
102-
discoveryApi.createAllAssetLinksById(encodedId, specificAssetIds);
97+
discoveryApi.deleteAllAssetLinksById(aasDescriptorId);
98+
discoveryApi.createAllAssetLinksById(aasDescriptorId, specificAssetIds);
10399
}
104100

105101
@Override
106102
public void removeAasDescriptor(@NonNull String aasDescriptorId) throws AasDescriptorNotFoundException {
107103
decorated.removeAasDescriptor(aasDescriptorId);
108-
discoveryApi.deleteAllAssetLinksById(Base64.getEncoder().encodeToString(aasDescriptorId.getBytes()));
104+
discoveryApi.deleteAllAssetLinksById(aasDescriptorId);
109105
}
110106

111107
@Override

0 commit comments

Comments
 (0)