Secure repository file paths and stream downloads - #1024
Merged
Conversation
Centralize repository file handling through FileRepositoryHelper for AAS thumbnails, submodel attachments, and AASX packages. Uploaded logical filenames are now validated as display names only, while stored repository ids are generated server-side. Stream thumbnail and attachment HTTP responses from the repository instead of materializing repository ids as local filesystem paths. Keep legacy File APIs compatible via safe temp-file/default fallbacks. Update replacement/delete flows to update domain references safely and clean up old repository entries after successful updates. Add regression coverage for path traversal names, absolute repository keys, stream handling, and authorization behavior.
Member
|
i approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes unsafe repository file handling for thumbnails, submodel attachments, and AASX packages.
Uploaded filenames are no longer used as repository ids or filesystem paths. They are treated as logical display names only, validated centrally, and stored as metadata while repository storage uses generated ids.
Changes
Added shared file lifecycle helpers in
FileRepositoryHelperUpdated AAS thumbnail handling
InputStreamFileAPIFileDoesNotExistExceptionUpdated submodel attachment handling
idShortPathUpdated AASX package handling
Preserved Java API compatibility
Tests