Skip to content

Adds AAS Discovery Integration for AAS Repository#726

Merged
aaronzi merged 12 commits into
eclipse-basyx:mainfrom
FriedJannik:feature/discoveryintegration
May 5, 2025
Merged

Adds AAS Discovery Integration for AAS Repository#726
aaronzi merged 12 commits into
eclipse-basyx:mainfrom
FriedJannik:feature/discoveryintegration

Conversation

@FriedJannik

Copy link
Copy Markdown
Member

Description of Changes

This PR adds AAS Discovery Integration for AAS Repository (Authorized and Unauthorized)

Related Issue

closes #604

BaSyx Configuration for Testing

AAS Files Used for Testing

Additional Information

@aaronzi aaronzi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this feature 👍🏻

Could you please update the BaSyx Examples where the discovery service is included

@aaronzi aaronzi merged commit a84f97b into eclipse-basyx:main May 5, 2025
33 checks passed
@seicke

seicke commented May 6, 2025

Copy link
Copy Markdown
Member

Really appreciate this feature, will test it soon.
Thanks a lot @FriedJannik

@seicke

seicke commented May 6, 2025

Copy link
Copy Markdown
Member

@FriedJannik Shouldn't the .env file also have been adjusted in the commit 0b99c07 (#726)?
From my point of view the example BaSyxSecured can not be working. The example is using BASYX_VERSION=2.0.0-milestone-04, but actually your feature is just integtrated in BASYX_VERSION=2.0.0-SNAPSHOT, isn't it?

@FriedJannik

Copy link
Copy Markdown
Member Author

@seicke You're right. I must have missed that. I will test (and fix) it asap :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AAS Discovery Integration

3 participants