Implement support for adding globalAssetId to Discovery Service#894
Merged
aaronzi merged 1 commit intoOct 21, 2025
Merged
Conversation
Contributor
Author
|
@aaronzi Is that okay? You assigned me :) It's my very first contribution in that repository. |
Member
|
Thanks for the PR. I will look into the code later today. What I can see from the checks is that you need to create an Eclipse Account and sign the Eclipse Contributor Agreement (ECA) with the same email that you used the sign your git commits |
Contributor
Author
|
Sure, @aaronzi |
Member
|
I removed your mail from my comment :) |
Contributor
Author
|
@aaronzi Done. Registered as a contributor. 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR implements support for propagating
globalAssetIdto the Discovery Service alongsidespecificAssetIdswhen creating or updating AAS descriptors in the Digital Twin Registry.Key changes:
collectAllAssetIds()private method that collects bothspecificAssetIdsandglobalAssetIdfrom AAS descriptorsglobalAssetIdis converted to aSpecificAssetIdwith the name"globalAssetId"before being sent to the Discovery ServiceinsertAasDescriptor()to propagateglobalAssetIdwhen presentreplaceAasDescriptor()to propagateglobalAssetIdwhen present, ensuring it's always called even with empty asset ID listsRelated Issue
Closes #893
BaSyx Configuration for Testing
No special configuration is required for testing these changes. The implementation uses Mockito for unit testing and does not require a running BaSyx instance.
All tests should pass successfully.
AAS Files Used for Testing
No external AAS files were required for testing. All test cases use programmatically created
AssetAdministrationShellDescriptorobjects with:specificAssetIdsandglobalAssetIdglobalAssetIdspecificAssetIds(regression testing)The test descriptors simulate realistic AAS configurations to verify the Discovery Service integration.
Additional Information