From bdfc864ca148a3867f553507c688f782627e5e03 Mon Sep 17 00:00:00 2001 From: FriedJannik Date: Mon, 10 Nov 2025 10:14:38 +0100 Subject: [PATCH 1/2] Disables PatchSubmodelElementByPathValueOnly Endpoint for SubmodelElementList --- .../http/SubmodelRepositoryApiHTTPController.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/basyx.submodelrepository/basyx.submodelrepository-http/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/http/SubmodelRepositoryApiHTTPController.java b/basyx.submodelrepository/basyx.submodelrepository-http/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/http/SubmodelRepositoryApiHTTPController.java index 8f265e237..fbe27d938 100644 --- a/basyx.submodelrepository/basyx.submodelrepository-http/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/http/SubmodelRepositoryApiHTTPController.java +++ b/basyx.submodelrepository/basyx.submodelrepository-http/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/http/SubmodelRepositoryApiHTTPController.java @@ -55,6 +55,7 @@ import org.eclipse.digitaltwin.basyx.pagination.GetSubmodelElementsResult; import org.eclipse.digitaltwin.basyx.submodelrepository.SubmodelRepository; import org.eclipse.digitaltwin.basyx.submodelrepository.http.pagination.GetSubmodelsResult; +import org.eclipse.digitaltwin.basyx.submodelservice.value.SubmodelElementListValue; import org.eclipse.digitaltwin.basyx.submodelservice.value.SubmodelElementValue; import org.eclipse.digitaltwin.basyx.submodelservice.value.SubmodelValueOnly; import org.springframework.beans.factory.annotation.Autowired; @@ -277,6 +278,9 @@ public ResponseEntity patchSubmodelByIdValueOnly(Base64UrlEncodedIdentifie } private ResponseEntity handleSubmodelElementValueSetRequest(Base64UrlEncodedIdentifier submodelIdentifier, String idShortPath, SubmodelElementValue body) { + if(body instanceof SubmodelElementListValue){ + return new ResponseEntity(HttpStatus.NOT_IMPLEMENTED); + } repository.setSubmodelElementValue(submodelIdentifier.getIdentifier(), idShortPath, body); return new ResponseEntity(HttpStatus.NO_CONTENT); } From 68d558fe20713ee7cd169e0d8243a9ec19118cf6 Mon Sep 17 00:00:00 2001 From: FriedJannik Date: Mon, 10 Nov 2025 11:43:51 +0100 Subject: [PATCH 2/2] Disables Tests for PatchSubmodelElementByPathValueOnly Endpoint for SubmodelElementList --- .../client/TestConnectedSubmodelElements.java | 6 ++---- .../http/SubmodelServiceSubmodelElementsTestSuiteHTTP.java | 2 ++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/basyx.submodelservice/basyx.submodelservice-client/src/test/java/org/eclipse/digitaltwin/basyx/submodelservice/client/TestConnectedSubmodelElements.java b/basyx.submodelservice/basyx.submodelservice-client/src/test/java/org/eclipse/digitaltwin/basyx/submodelservice/client/TestConnectedSubmodelElements.java index 153d9fc33..83a3781a0 100644 --- a/basyx.submodelservice/basyx.submodelservice-client/src/test/java/org/eclipse/digitaltwin/basyx/submodelservice/client/TestConnectedSubmodelElements.java +++ b/basyx.submodelservice/basyx.submodelservice-client/src/test/java/org/eclipse/digitaltwin/basyx/submodelservice/client/TestConnectedSubmodelElements.java @@ -90,10 +90,7 @@ import org.eclipse.digitaltwin.basyx.submodelservice.value.mapper.RelationshipElementValueMapper; import org.eclipse.digitaltwin.basyx.submodelservice.value.mapper.SubmodelElementCollectionValueMapper; import org.eclipse.digitaltwin.basyx.submodelservice.value.mapper.SubmodelElementListValueMapper; -import org.junit.After; -import org.junit.AfterClass; -import org.junit.BeforeClass; -import org.junit.Test; +import org.junit.*; import org.springframework.boot.builder.SpringApplicationBuilder; import org.springframework.context.ConfigurableApplicationContext; @@ -388,6 +385,7 @@ public void getSubmodelElementListValue() { assertEquals(1, submodelElementList.getValue().getSubmodelElementValues().size()); } + @Ignore("Patch Endpoint for SubmodelElementList Values is disabled as it is not working.") @Test public void setSubmodelElementListValue() { DefaultSubmodelElementList submodelElementList = getDefaultSubmodelElementList(); diff --git a/basyx.submodelservice/basyx.submodelservice-http/src/test/java/org/eclipse/digitaltwin/basyx/submodelservice/http/SubmodelServiceSubmodelElementsTestSuiteHTTP.java b/basyx.submodelservice/basyx.submodelservice-http/src/test/java/org/eclipse/digitaltwin/basyx/submodelservice/http/SubmodelServiceSubmodelElementsTestSuiteHTTP.java index cb59737b5..27615504f 100644 --- a/basyx.submodelservice/basyx.submodelservice-http/src/test/java/org/eclipse/digitaltwin/basyx/submodelservice/http/SubmodelServiceSubmodelElementsTestSuiteHTTP.java +++ b/basyx.submodelservice/basyx.submodelservice-http/src/test/java/org/eclipse/digitaltwin/basyx/submodelservice/http/SubmodelServiceSubmodelElementsTestSuiteHTTP.java @@ -49,6 +49,7 @@ import org.eclipse.digitaltwin.basyx.http.serialization.BaSyxHttpTestUtils; import org.eclipse.digitaltwin.basyx.submodelservice.DummySubmodelFactory; import org.eclipse.digitaltwin.basyx.submodelservice.SubmodelServiceHelper; +import org.junit.Ignore; import org.junit.Test; import org.springframework.core.io.ClassPathResource; import org.springframework.http.HttpStatus; @@ -360,6 +361,7 @@ public void getSubmodelElementListValue() throws IOException, ParseException { BaSyxHttpTestUtils.assertSameJSONContent(expectedValue, BaSyxHttpTestUtils.getResponseAsString(response)); } + @Ignore("Patch Endpoint for SubmodelElementList Values is disabled as it is not working.") @Test public void setSubmodelElementListValue() throws IOException, ParseException { String expectedValue = getJSONValueAsString("value/setSubmodelElementListValue.json");