Add unused / bad practice imports (F4)

Author: JAB1305

compliance_tool/aas_compliance_tool/compliance_check_aasx.py

@@ -12,7 +12,6 @@
 :class:`LogRecords <logging.LogRecord>`
 """
 import datetime
-import io
 import logging
 from typing import Optional, Tuple, cast
 
@@ -23,9 +22,7 @@
 from basyx.aas.adapter.xml import xml_deserialization
 from basyx.aas.examples.data import create_example_aas_binding, example_aas
 from basyx.aas.examples.data._helper import AASDataChecker, DataChecker
-from lxml import etree  # type: ignore
 
-from aas_compliance_tool import compliance_check_json, compliance_check_xml
 from aas_compliance_tool.state_manager import ComplianceToolStateManager, Status
 
 

compliance_tool/aas_compliance_tool/compliance_check_json.py

@@ -11,10 +11,8 @@
 :class:`~basyx.aas.compliance_tool.state_manager.ComplianceToolStateManager` by adding new steps and associated
 :class:`LogRecords <logging.LogRecord>`
 """
-import json
 import logging
-import os
-from typing import IO, Optional
+from typing import Optional
 
 from basyx.aas import model
 from basyx.aas.adapter.json import json_deserialization

compliance_tool/aas_compliance_tool/compliance_check_xml.py

@@ -12,14 +12,12 @@
 :class:`LogRecords <logging.LogRecord>`
 """
 import logging
-import os
 from typing import Optional
 
 from basyx.aas import model
 from basyx.aas.adapter.xml import xml_deserialization
 from basyx.aas.examples.data import create_example, example_aas
 from basyx.aas.examples.data._helper import AASDataChecker
-from lxml import etree  # type: ignore
 
 from aas_compliance_tool.state_manager import ComplianceToolStateManager, Status
 

compliance_tool/test/test_aas_compliance_tool.py

@@ -7,7 +7,6 @@
 import datetime
 import hashlib
 import io
-import os
 import tempfile
 import unittest
 from contextlib import redirect_stderr, redirect_stdout

ruff.toml

@@ -18,6 +18,7 @@ select = [
     "D204", "D211", "D201", "D300",  # basic docstring formatting
     "I",       # isort
     "F8",      # pyflakes: undefined/unused names
+    "F4",      # pyflakes: imports/__future__
 ]
 
 # TODO: Revisit these
@@ -31,7 +32,6 @@ ignore = [
     "A",       # prevent shadowing of python builtins
     "FIX",     # prevent the creation of T0DO / F1XME comments
     # Checked, need manual work:
-    "F4",      # pyflakes: imports/__future__
     "PIE",     # small readability improvements
     "PYI",     # typing best practices
     # Evaluate if we want to use:

sdk/basyx/aas/adapter/json/__init__.py

@@ -31,3 +31,16 @@
     object_store_to_json,
     write_aas_json_file,
 )
+
+__all__ = [
+    "AASFromJsonDecoder",
+    "StrictAASFromJsonDecoder",
+    "StrictStrippedAASFromJsonDecoder",
+    "StrippedAASFromJsonDecoder",
+    "read_aas_json_file",
+    "read_aas_json_file_into",
+    "AASToJsonEncoder",
+    "StrippedAASToJsonEncoder",
+    "object_store_to_json",
+    "write_aas_json_file",
+]

sdk/basyx/aas/adapter/json/json_serialization.py

@@ -29,7 +29,6 @@
 
 import base64
 import contextlib
-import inspect
 import io
 import json
 from typing import (

sdk/basyx/aas/adapter/xml/__init__.py

@@ -26,3 +26,18 @@
     write_aas_xml_element,
     write_aas_xml_file,
 )
+
+__all__ = [
+    "AASFromXmlDecoder",
+    "StrictAASFromXmlDecoder",
+    "StrictStrippedAASFromXmlDecoder",
+    "StrippedAASFromXmlDecoder",
+    "XMLConstructables",
+    "read_aas_xml_element",
+    "read_aas_xml_file",
+    "read_aas_xml_file_into",
+    "object_store_to_xml_element",
+    "object_to_xml_element",
+    "write_aas_xml_element",
+    "write_aas_xml_file",
+]

sdk/basyx/aas/adapter/xml/xml_serialization.py

@@ -32,7 +32,7 @@
 """
 
 import base64
-from typing import Callable, Dict, Optional, Type
+from typing import Dict, Optional, Type
 
 from lxml import etree
 

sdk/basyx/aas/model/__init__.py

@@ -8,7 +8,8 @@
     from basyx.aas.model import AssetAdministrationShell, Submodel, Property
 """
 
-from . import datatypes
+import inspect
+
 from .aas import *
 from .base import *
 from .concept import ConceptDescription