Skip to content

Commit 9d43b69

Browse files
committed
add MyPy checking, remove codeblock checking
1 parent 06e51e7 commit 9d43b69

2 files changed

Lines changed: 22 additions & 25 deletions

File tree

.github/workflows/ci.yml

Lines changed: 22 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -260,8 +260,8 @@ jobs:
260260
run: |
261261
pycodestyle --count --max-line-length 120 ./aas_compliance_tool test
262262
263-
compliance-tool-readme-codeblocks:
264-
# This job runs the same static code analysis (mypy and pycodestyle) on the codeblocks in our docstrings.
263+
compliance-tool-package:
264+
# This job checks if we can build our compliance_tool package
265265
runs-on: ubuntu-latest
266266

267267
defaults:
@@ -273,42 +273,43 @@ jobs:
273273
uses: actions/setup-python@v5
274274
with:
275275
python-version: ${{ env.X_PYTHON_MIN_VERSION }}
276-
- name: Install Python dependencies
277-
# install the local sdk in editable mode so it does not get overwritten
276+
- name: Install dependencies
278277
run: |
279278
python -m pip install --upgrade pip
280-
pip install -e ../sdk[dev]
281-
pip install .[dev]
282-
- name: Check typing with MyPy
283-
run: |
284-
mypy <(codeblocks python README.md)
285-
- name: Check code style with PyCodestyle
286-
run: |
287-
codeblocks --wrap python README.md | pycodestyle --count --max-line-length 120 -
288-
- name: Run readme codeblocks with Python
279+
pip install build
280+
- name: Create source and wheel dist
289281
run: |
290-
codeblocks python README.md | python
282+
python -m build
291283
292-
compliance-tool-package:
293-
# This job checks if we can build our compliance_tool package
284+
server-test:
285+
# TODO: This job runs the unittests on the python versions specified down at the matrix
286+
# and aas-test-engines on the server
287+
288+
289+
server-static-analysis:
290+
# This job runs static code analysis, namely pycodestyle and mypy
294291
runs-on: ubuntu-latest
295292

296293
defaults:
297294
run:
298-
working-directory: ./compliance_tool
295+
working-directory: ./server
299296
steps:
300297
- uses: actions/checkout@v4
301298
- name: Set up Python ${{ env.X_PYTHON_MIN_VERSION }}
302299
uses: actions/setup-python@v5
303300
with:
304301
python-version: ${{ env.X_PYTHON_MIN_VERSION }}
305-
- name: Install dependencies
302+
- name: Install Python dependencies
306303
run: |
307304
python -m pip install --upgrade pip
308-
pip install build
309-
- name: Create source and wheel dist
305+
pip install ../sdk
306+
pip install .[dev]
307+
- name: Check typing with MyPy
310308
run: |
311-
python -m build
309+
mypy ./server test
310+
- name: Check code style with PyCodestyle
311+
run: |
312+
pycodestyle --count --max-line-length 120 ./server test
312313
313314
server-package:
314315
# This job checks if we can build our server package

server/app/pyproject.toml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@ classifiers = [
3636
]
3737
requires-python = ">=3.9"
3838
dependencies = [
39-
# While we install the sdk locally, this dependency needs to be commented out
40-
# "basyx-python-sdk>=1.2.0,<2", #TODO: Think about the version
4139
"urllib3>=1.26,<3",
4240
"Werkzeug>=3.0.3,<4",
4341
]
@@ -47,11 +45,9 @@ dev = [
4745
"mypy",
4846
"pycodestyle",
4947
"codeblocks",
50-
"coverage",
5148
"schemathesis~=3.7",
5249
"jsonschema~=4.7",
5350
"hypothesis~=6.13",
54-
"types-python-dateutil",
5551
]
5652

5753
[project.urls]

0 commit comments

Comments
 (0)