Add unused / bad practice imports (F4)

JAB1305 · JAB1305 · commit d753f244f3bc · 2026-07-19T17:39:33.000+02:00
diff --git a/ruff.toml b/ruff.toml
@@ -18,6 +18,7 @@ select = [
     "D204", "D211", "D201", "D300",  # basic docstring formatting
     "I",       # isort
     "F8",      # pyflakes: undefined/unused names
+    "F4",      # pyflakes: imports/__future__
 ]
 
 # TODO: Revisit these
@@ -31,7 +32,6 @@ ignore = [
     "A",       # prevent shadowing of python builtins
     "FIX",     # prevent the creation of T0DO / F1XME comments
     # Checked, need manual work:
-    "F4",      # pyflakes: imports/__future__
     "PIE",     # small readability improvements
     "PYI",     # typing best practices
     # Evaluate if we want to use:
diff --git a/sdk/basyx/aas/adapter/json/__init__.py b/sdk/basyx/aas/adapter/json/__init__.py
@@ -31,3 +31,16 @@
     object_store_to_json,
     write_aas_json_file,
 )
+
+__all__ = [
+    "AASFromJsonDecoder",
+    "StrictAASFromJsonDecoder",
+    "StrictStrippedAASFromJsonDecoder",
+    "StrippedAASFromJsonDecoder",
+    "read_aas_json_file",
+    "read_aas_json_file_into",
+    "AASToJsonEncoder",
+    "StrippedAASToJsonEncoder",
+    "object_store_to_json",
+    "write_aas_json_file",
+]
diff --git a/sdk/basyx/aas/adapter/json/json_serialization.py b/sdk/basyx/aas/adapter/json/json_serialization.py
@@ -29,7 +29,6 @@
 
 import base64
 import contextlib
-import inspect
 import io
 import json
 from typing import (
diff --git a/sdk/basyx/aas/adapter/xml/__init__.py b/sdk/basyx/aas/adapter/xml/__init__.py
@@ -26,3 +26,18 @@
     write_aas_xml_element,
     write_aas_xml_file,
 )
+
+__all__ = [
+    "AASFromXmlDecoder",
+    "StrictAASFromXmlDecoder",
+    "StrictStrippedAASFromXmlDecoder",
+    "StrippedAASFromXmlDecoder",
+    "XMLConstructables",
+    "read_aas_xml_element",
+    "read_aas_xml_file",
+    "read_aas_xml_file_into",
+    "object_store_to_xml_element",
+    "object_to_xml_element",
+    "write_aas_xml_element",
+    "write_aas_xml_file",
+]
diff --git a/sdk/basyx/aas/adapter/xml/xml_serialization.py b/sdk/basyx/aas/adapter/xml/xml_serialization.py
@@ -32,7 +32,7 @@
 """
 
 import base64
-from typing import Callable, Dict, Optional, Type
+from typing import Dict, Optional, Type
 
 from lxml import etree
 
diff --git a/sdk/basyx/aas/model/__init__.py b/sdk/basyx/aas/model/__init__.py
@@ -8,7 +8,8 @@
     from basyx.aas.model import AssetAdministrationShell, Submodel, Property
 """
 
-from . import datatypes
+import inspect
+
 from .aas import *
 from .base import *
 from .concept import ConceptDescription
diff --git a/sdk/basyx/aas/model/base.py b/sdk/basyx/aas/model/base.py
@@ -10,7 +10,6 @@
 """
 
 import abc
-import inspect
 import itertools
 import re
 from enum import Enum, unique
@@ -927,7 +926,6 @@ def _set_id_short(self, id_short: Optional[NameType]):
                     f"id_short of {self!r} cannot be unset, since it is already "
                     f"contained in {self.parent!r}",
                 )
-            from .submodel import SubmodelElementList
 
             for set_ in self.parent.namespace_element_sets:
                 if set_.contains_id("id_short", id_short):
diff --git a/sdk/basyx/aas/model/submodel.py b/sdk/basyx/aas/model/submodel.py
@@ -16,7 +16,6 @@
     Iterable,
     List,
     Optional,
-    Set,
     Type,
     TypeVar,
     Union,
diff --git a/sdk/test/adapter/aasx/test_aasx.py b/sdk/test/adapter/aasx/test_aasx.py
@@ -19,7 +19,6 @@
 from basyx.aas.examples.data import (
     _helper,
     example_aas,
-    example_aas_mandatory_attributes,
 )
 
 
diff --git a/sdk/test/backend/test_couchdb.py b/sdk/test/backend/test_couchdb.py
@@ -6,7 +6,6 @@
 # SPDX-License-Identifier: MIT
 import unittest
 import unittest.mock
-import urllib.error
 
 from basyx.aas.backend import couchdb
 from basyx.aas.examples.data.example_aas import *
diff --git a/sdk/test/examples/test_tutorials.py b/sdk/test/examples/test_tutorials.py
@@ -32,7 +32,7 @@ def test_tutorial_create_simple_aas(self):
         next(iter(tutorial_create_simple_aas.aas.submodel)).resolve(store)
 
     def test_tutorial_storage(self):
-        from basyx.aas.examples import tutorial_storage
+        pass
         # The tutorial already includes assert statements for the relevant points. So no further checks are required.
 
     @unittest.skipUnless(
@@ -44,24 +44,22 @@ def test_tutorial_storage(self):
         ),
     )
     def test_tutorial_backend_couchdb(self):
-        from basyx.aas.examples import tutorial_backend_couchdb
+        pass
 
     def test_tutorial_serialization_deserialization_json(self):
         with temporary_workingdirectory():
-            from basyx.aas.examples import tutorial_serialization_deserialization
 
             pass
         # The tutorial already includes assert statements for the relevant points. So no further checks are required.
 
     def test_tutorial_aasx(self):
         with temporary_workingdirectory():
-            from basyx.aas.examples import tutorial_aasx
 
             pass
         # The tutorial already includes assert statements for the relevant points. So no further checks are required.
 
     def test_tutorial_navigate_aas(self):
-        from basyx.aas.examples import tutorial_navigate_aas
+        pass
         # The tutorial already includes assert statements for the relevant points. So no further checks are required
 
 
diff --git a/sdk/test/model/test_base.py b/sdk/test/model/test_base.py
@@ -6,9 +6,7 @@
 # SPDX-License-Identifier: MIT
 
 import unittest
-from collections import OrderedDict
 from typing import Callable, Dict, Iterable, List, Optional, Type, TypeVar
-from unittest import mock
 
 from basyx.aas import model
 from basyx.aas.examples.data import example_aas

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@`
`19`	`19`	`from basyx.aas.examples.data import (`
`20`	`20`	`_helper,`
`21`	`21`	`example_aas,`
`22`		`- example_aas_mandatory_attributes,`
`23`	`22`	`)`
`24`	`23`
`25`	`24`