Skip to content

Commit efbf66f

Browse files
committed
Fix: image naming in build-server action
1 parent f41d418 commit efbf66f

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

.github/actions/build-server/action.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ inputs:
2020
outputs:
2121
image-digest:
2222
description: The image name + digest of the built image
23-
value: ${{ steps.build.outputs.imageid }}@${{ steps.build.outputs.digest }}
23+
value: ${{ steps.naming.outputs.image-name }}@${{ steps.build.outputs.digest }}
2424

2525
runs:
2626
using: composite
@@ -32,25 +32,26 @@ runs:
3232
uses: docker/setup-buildx-action@v4
3333

3434
- name: Generate Image Title
35-
id: capitalize
35+
id: naming
3636
shell: bash
3737
run: |
3838
profile="${{ inputs.server-profile }}"
3939
echo "profile-title=${profile^}" >> "$GITHUB_OUTPUT"
40+
echo "image-name=eclipsebasyx/basyx-python-${{ inputs.server-profile }}" >> $GITHUB_OUTPUT
4041
4142
- name: Extract Docker image metadata
4243
id: meta
4344
uses: docker/metadata-action@v5
4445
with:
45-
images: eclipsebasyx/basyx-python-${{ inputs.server-profile }}
46+
images: ${{ steps.naming.outputs.image-name }}
4647
# This fetches the latest git tag and adds an additional "latest" to it, so e.g. `2.1.0,latest`
4748
tags: |
4849
type=semver,pattern={{version}}
4950
type=raw,value=latest,enable=${{ inputs.publish == 'true' && true || false }}
5051
type=sha,prefix=pr-,enable=${{ inputs.load == 'true' && true || false }}
5152
labels: |
52-
org.opencontainers.image.title=BaSyx Python ${{ steps.capitalize.outputs.profile-title }} Service
53-
org.opencontainers.image.description=Eclipse BaSyx Python SDK - ${{ steps.capitalize.outputs.profile-title }} HTTP Server
53+
org.opencontainers.image.title=BaSyx Python ${{ steps.naming.outputs.profile-title }} Service
54+
org.opencontainers.image.description=Eclipse BaSyx Python SDK - ${{ steps.naming.outputs.profile-title }} HTTP Server
5455
org.opencontainers.image.source=https://github.com/eclipse-basyx/basyx-python-sdk/tree/main/server
5556
org.opencontainers.image.licenses=MIT
5657

.github/workflows/pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ jobs:
357357
platform: linux/amd64
358358
- name: Run container
359359
run: |
360-
docker run -d --name basyx-python-${{ matrix.service }} -p 9080:80 ${{ steps.build.outputs.image-digest }}
360+
docker run -d --name basyx-python-${{ matrix.service }} -p 9080:80 --pull=never ${{ steps.build.outputs.image-digest }}
361361
- name: Wait for container and server initialization
362362
run: |
363363
timeout 30s bash -c '

0 commit comments

Comments
 (0)