CI: extend python version check to Dockerfiles

Previously we checked in the pull_request CI only that all `pyproject.toml`
files requrire a python version that lies in bounds with
`X_PYTHON_MIN_VERSION` and `X_PYTHON_MAX_VERSION`.

We extended the check to also check the `Dockerfile` of the server
directory.

Author: hpoeche

.github/workflows/pr.yml

@@ -44,14 +44,23 @@ jobs:
 
       - name: Check Python Versions coincide with all pyproject.toml Files
         run: |
-          for file in ../../sdk/pyproject.toml ../../compliance_tool/pyproject.toml; do
+          for file in ../../sdk/pyproject.toml ../../compliance_tool/pyproject.toml ../../server/pyproject.toml; do
             python check_python_versions_coincide.py \
               $file \
               ${{ env.X_PYTHON_MIN_VERSION }} \
               ${{ env.X_PYTHON_MAX_VERSION }}
           done
 
-      # Todo: Check other pyproject.toml here as well, as we add them
+      - name: Check Python Versions coincide with all Dockerfiles
+        run: |
+          for file in ../../server/docker/repository/Dockerfile \
+                      ../../server/docker/registry/Dockerfile  \
+                      ../../server/docker/discovery/Dockerfile; do
+            python check_python_versions_coincide.py --docker \
+              $file \
+              ${{ env.X_PYTHON_MIN_VERSION }} \
+              ${{ env.X_PYTHON_MAX_VERSION }}
+          done
 
   sdk-test:
     # This job runs the unittests on the python versions specified down at the matrix

etc/scripts/check_python_versions_coincide.py

@@ -1,48 +1,67 @@
 """
-This helper script checks if the Python versions defined in a `pyproject.toml` coincide with the given `min_version`
-and `max_version` and returns an error if they don't.
+This helper script checks if the Python versions defined in a `pyproject.toml` or `Dockerfile` coincide with the given
+`min_version` and `max_version` and returns an error if they don't.
 """
 import argparse
 import re
 import sys
 
 from packaging.version import InvalidVersion, Version
 
+def get_version_pyproject(file_path: str) -> str:
+    with open(file_path, "r") as f:
+        pyproject_content = f.read()
 
-def main(pyproject_toml_path: str, min_version: str, max_version: str) -> None:
+    match = re.search(r'requires-python\s*=\s*">=([\d.]+)"', pyproject_content)
+    if not match:
+        print(f"Error: `requires-python` field not found or invalid format in `{file_path}`")
+        sys.exit(1)
+
+    return match.group(1)
+
+def get_version_dockerfile(file_path: str) -> str:
+    with open(file_path, "r") as f:
+        pyproject_content = f.read()
+
+    match = re.search(r'^FROM\s+python:([\d.]+)', pyproject_content)
+    if not match:
+        print(f"Error: Definition of base image `FROM python:x.x` not found in `{file_path}`")
+        sys.exit(1)
+
+    return match.group(1)
+
+def main(file_path: str, is_dockerfile: bool, min_version: str, max_version: str) -> None:
     # Load and check `requires-python` version from `pyproject.toml`
     try:
-        with open(pyproject_toml_path, "r") as f:
-            pyproject_content = f.read()
-
-        match = re.search(r'requires-python\s*=\s*">=([\d.]+)"', pyproject_content)
-        if not match:
-            print(f"Error: `requires-python` field not found or invalid format in `{pyproject_toml_path}`")
-            sys.exit(1)
+        if is_dockerfile:
+            used_version = get_version_dockerfile(file_path)
+        else:
+            used_version = get_version_pyproject(file_path)
 
-        pyproject_version = match.group(1)
-        if Version(pyproject_version) < Version(min_version):
-            print(f"Error: Python version in `{pyproject_toml_path}` `requires-python` ({pyproject_version}) "
+        if Version(used_version) < Version(min_version):
+            print(f"Error: Python version in `{file_path}` ({used_version}) "
                   f"is smaller than `min_version` ({min_version}).")
             sys.exit(1)
 
     except FileNotFoundError:
-        print(f"Error: File not found: `{pyproject_toml_path}`.")
+        print(f"Error: File not found: `{file_path}`.")
         sys.exit(1)
 
-    print(f"Success: Version in pyproject.toml `requires-python` (>={pyproject_version}) "
+    print(f"Success: Version in `{file_path}` ({used_version}) "
           f"matches expected versions ([{min_version} to {max_version}]).")
 
 
 if __name__ == "__main__":
-    parser = argparse.ArgumentParser(description="Check Python version support and alignment with pyproject.toml.")
-    parser.add_argument("pyproject_toml_path", help="Path to the `pyproject.toml` file to check.")
+    parser = argparse.ArgumentParser(description="Check Python version support and alignment with pyproject.toml or Dockerfile.")
+    parser.add_argument("file_path", help="Path to the `pyproject.toml` or `Dockerfile` file to check.")
+    parser.add_argument("--docker", action="store_true",
+                        help="Set, if checking a `Dockerfile`, otherwise `pyproject.toml` is assumed.")
     parser.add_argument("min_version", help="The minimum Python version.")
     parser.add_argument("max_version", help="The maximum Python version.")
     args = parser.parse_args()
 
     try:
-        main(args.pyproject_toml_path, args.min_version, args.max_version)
+        main(args.file_path, args.docker, args.min_version, args.max_version)
     except InvalidVersion:
         print("Error: Invalid version format provided.")
         sys.exit(1)